From: Takashi Iwai <tiwai@suse.de>
To: August Wikerfors <git@augustwikerfors.se>
Cc: Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
Baojun Xu <baojun.xu@ti.com>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Antheas Kapenekakis <lkml@antheas.dev>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/tas2781: properly initialize speaker_id for TAS2563
Date: Tue, 23 Dec 2025 10:51:00 +0100 [thread overview]
Message-ID: <87o6npil17.wl-tiwai@suse.de> (raw)
In-Reply-To: <20251222194704.87232-1-git@augustwikerfors.se>
On Mon, 22 Dec 2025 20:47:04 +0100,
August Wikerfors wrote:
>
> After speaker id retrieval was refactored to happen in tas2781_read_acpi,
> devices that do not use a speaker id need a negative speaker_id value
> instead of NULL, but no initialization was added to the TAS2563 code path.
> This causes the driver to attempt to load a non-existent firmware file name
> with a speaker id of 0 ("TAS2XXX38700.bin") instead of the correct file
> name without a speaker id ("TAS2XXX3870.bin"), resulting in low volume and
> these dmesg errors:
>
> tas2781-hda i2c-INT8866:00: Direct firmware load for TAS2XXX38700.bin failed with error -2
> tas2781-hda i2c-INT8866:00: tasdevice_dsp_parser: load TAS2XXX38700.bin error
> tas2781-hda i2c-INT8866:00: dspfw load TAS2XXX38700.bin error
> [...]
> tas2781-hda i2c-INT8866:00: tasdevice_prmg_load: Firmware is NULL
>
> Fix this by setting speaker_id to -1 as is done for other models.
>
> Fixes: 945865a0ddf3 ("ALSA: hda/tas2781: fix speaker id retrieval for multiple probes")
> Cc: stable@vger.kernel.org
> Signed-off-by: August Wikerfors <git@augustwikerfors.se>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2025-12-23 9:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-22 19:47 [PATCH] ALSA: hda/tas2781: properly initialize speaker_id for TAS2563 August Wikerfors
2025-12-23 9:51 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o6npil17.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=baojun.xu@ti.com \
--cc=git@augustwikerfors.se \
--cc=kevin-lu@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=lkml@antheas.dev \
--cc=perex@perex.cz \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox