From: Takashi Iwai <tiwai@suse.de>
To: "Cássio Gabriel" <cassiogabrielcontato@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Brown <broonie@kernel.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
notify@kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: qcom: Guard sideband endpoint removal
Date: Fri, 12 Jun 2026 11:03:27 +0200 [thread overview]
Message-ID: <87pl1wi10g.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260611-alsa-usb-qcom-guard-sideband-endpoint-removal-v1-1-00e73787c156@gmail.com>
On Thu, 11 Jun 2026 15:57:22 +0200,
Cássio Gabriel wrote:
>
> qmi_stop_session() conditionally looks up the cached data and sync
> endpoints, but removes each endpoint unconditionally.
>
> The data endpoint is always present for an active offload stream, while
> the sync endpoint is optional. When no sync endpoint exists, ep still
> refers to the data endpoint and the code attempts to remove that endpoint
> a second time. The current sideband implementation rejects the duplicate
> removal, but the teardown path should not pass an unrelated endpoint for
> an absent sync endpoint.
>
> Only look up and remove an endpoint when its cached pipe exists, check the
> lookup result, and clear the cached pipe after handling it. This matches
> the normal stream-disable path.
>
> Fixes: 326bbc348298 ("ALSA: usb-audio: qcom: Introduce QC USB SND offloading support")
> Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Applied to for-next branch now. Thanks.
Takashi
prev parent reply other threads:[~2026-06-12 9:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 13:57 [PATCH] ALSA: usb-audio: qcom: Guard sideband endpoint removal Cássio Gabriel
2026-06-12 9:03 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pl1wi10g.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=broonie@kernel.org \
--cc=cassiogabrielcontato@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=notify@kernel.org \
--cc=perex@perex.cz \
--cc=quic_wcheng@quicinc.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox