public inbox for linux-sound@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Hristiyan <hristian.anchev@gmail.com>
Cc: tiwai@suse.com, perex@perex.cz, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add support for HP ENVY x360 Convertible 15-ee0xxx
Date: Mon, 13 Apr 2026 07:24:26 +0200	[thread overview]
Message-ID: <87pl43whyt.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260412224316.29010-1-hristian.anchev@gmail.com>

On Mon, 13 Apr 2026 00:43:16 +0200,
Hristiyan wrote:
> 
> The HP ENVY x360 Convertible 15-ee0xxx (PCI SSID 103c:876f) has a
> Realtek ALC245 codec with Cirrus Logic CS35L41 smart amplifiers
> connected via I2C. The BIOS does not provide the required ACPI _DSD
> properties for the amplifiers, causing the speakers to produce no
> sound under Linux.
> 
> Add an entry using ALC245_FIXUP_CS35L41_I2C_2 to enable the
> internal speakers on this device.
> 
> Signed-off-by: Hristiyan <hristian.anchev@gmail.com>

Please use the full name for From and Signed-off-by.
Also, doesn't it need a hook for the mute-LED like other quirks for HP machines?


thanks,

Takashi

> ---
>  sound/hda/codecs/realtek/alc269.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index 45f9d6487..d05c0c57a 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -6919,6 +6919,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x103c, 0x8756, "HP ENVY Laptop 13-ba0xxx", ALC245_FIXUP_HP_X360_MUTE_LEDS),
>  	SND_PCI_QUIRK(0x103c, 0x8760, "HP EliteBook 8{4,5}5 G7", ALC285_FIXUP_HP_BEEP_MICMUTE_LED),
>  	SND_PCI_QUIRK(0x103c, 0x876e, "HP ENVY x360 Convertible 13-ay0xxx", ALC245_FIXUP_HP_X360_MUTE_LEDS),
> +	SND_PCI_QUIRK(0x103c, 0x876f, "HP ENVY x360 Convertible 15-ee0xxx", ALC245_FIXUP_CS35L41_I2C_2),
>  	SND_PCI_QUIRK(0x103c, 0x877a, "HP", ALC285_FIXUP_HP_MUTE_LED),
>  	SND_PCI_QUIRK(0x103c, 0x877d, "HP", ALC236_FIXUP_HP_MUTE_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8780, "HP ZBook Fury 17 G7 Mobile Workstation",
> -- 
> 2.53.0
> 

      reply	other threads:[~2026-04-13  5:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-12 22:43 [PATCH] ALSA: hda/realtek: Add support for HP ENVY x360 Convertible 15-ee0xxx Hristiyan
2026-04-13  5:24 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pl43whyt.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=hristian.anchev@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox