Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jonathan Lane <jon@borg.moe>
Cc: linux-sound@vger.kernel.org
Subject: Re: [PATCH] enable headset mic on Latitude 5420 Rugged
Date: Sun, 08 Jun 2025 11:31:33 +0200	[thread overview]
Message-ID: <87plfe8tqi.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250529185014.28503-1-jon@borg.moe>

On Thu, 29 May 2025 20:50:14 +0200,
Jonathan Lane wrote:
> 
> ---

Thanks for the patch.  But the patch description is missing, and above
all, your Signed-off-by tag is missing.  The latter is a legal
requirement for merging to the upstream.
The code change itself looks OK, so could you resubmit a properly
formatted patch?

Please check Documentation/process/submitting-patches.rst for
details.


thanks,

Takashi


>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index cd0d7ba7320e..261ba1a60015 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -10509,6 +10509,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1028, 0x0871, "Dell Precision 3630", ALC255_FIXUP_DELL_HEADSET_MIC),
>  	SND_PCI_QUIRK(0x1028, 0x0872, "Dell Precision 3630", ALC255_FIXUP_DELL_HEADSET_MIC),
>  	SND_PCI_QUIRK(0x1028, 0x0873, "Dell Precision 3930", ALC255_FIXUP_DUMMY_LINEOUT_VERB),
> +	SND_PCI_QUIRK(0x1028, 0x0879, "Dell Latitude 5420 Rugged", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE)
>  	SND_PCI_QUIRK(0x1028, 0x08ad, "Dell WYSE AIO", ALC225_FIXUP_DELL_WYSE_AIO_MIC_NO_PRESENCE),
>  	SND_PCI_QUIRK(0x1028, 0x08ae, "Dell WYSE NB", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE),
>  	SND_PCI_QUIRK(0x1028, 0x0935, "Dell", ALC274_FIXUP_DELL_AIO_LINEOUT_VERB),
> -- 
> 2.49.0
> 
> 

      reply	other threads:[~2025-06-08  9:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-29 18:50 [PATCH] enable headset mic on Latitude 5420 Rugged Jonathan Lane
2025-06-08  9:31 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plfe8tqi.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=jon@borg.moe \
    --cc=linux-sound@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox