From: Takashi Iwai <tiwai@suse.de>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: <tiwai@suse.com>, <soyer@irl.hu>, <shenghao-ding@ti.com>,
<perex@perex.cz>, <linux-kernel@vger.kernel.org>,
<linux-sound@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<patches@opensource.cirrus.com>
Subject: Re: [PATCH 0/2] ALSA: hda: Move component binding support into separate library
Date: Wed, 24 Jan 2024 14:43:47 +0100 [thread overview]
Message-ID: <87plxqlucs.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240124112607.77614-1-rf@opensource.cirrus.com>
On Wed, 24 Jan 2024 12:26:05 +0100,
Richard Fitzgerald wrote:
>
> The Cirrus Logic amplifiers are currently paired with Realtek HDA codecs.
> But they could be used with other codecs. To prepare for this, these two
> patches move the manager side of the component binding out of the Realtek
> driver into a library module.
>
> The first patch tweaks the CS35L41 code so that it is not hardcoded to
> CS35L41, and changes the TAS2781 handling so that it re-uses that code
> instead of having a near-identical copy of it.
>
> Can someone please test that these two patches don't break TAS2781?
> I have checked that they should work in theory but I don't have hardware
> to test on.
>
> Richard Fitzgerald (2):
> ALSA: hda: realtek: Re-work CS35L41 fixups to re-use for other amps
> ALSA: hda: realtek: Move hda_component implementation to module
Through a quick glance, it looks good.
I'll wait for the verification for TAS codec for a while.
thanks,
Takashi
next prev parent reply other threads:[~2024-01-24 13:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 11:26 [PATCH 0/2] ALSA: hda: Move component binding support into separate library Richard Fitzgerald
2024-01-24 11:26 ` [PATCH 1/2] ALSA: hda: realtek: Re-work CS35L41 fixups to re-use for other amps Richard Fitzgerald
2024-01-24 11:26 ` [PATCH 2/2] ALSA: hda: realtek: Move hda_component implementation to module Richard Fitzgerald
2024-01-24 13:43 ` Takashi Iwai [this message]
2024-01-25 9:05 ` [PATCH 0/2] ALSA: hda: Move component binding support into separate library Takashi Iwai
2024-01-24 21:55 ` Gergo Koteles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plxqlucs.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox