From: Takashi Iwai <tiwai@suse.de>
To: Sally Marcher <marcher@student.tugraz.at>
Cc: linux-sound@vger.kernel.org, tiwai@suse.com, perex@perex.cz,
Alexander Tsoy <alexander@tsoy.me>
Subject: Re: [PATCH] ALSA: usb-audio: MOTU MicroBook II playback fix
Date: Tue, 27 Oct 2026 08:33:00 +0100 [thread overview]
Message-ID: <87qzhb38er.wl-tiwai@suse.de> (raw)
In-Reply-To: <d5dfd044-69f6-4fc3-9884-6599d88afb55@student.tugraz.at>
On Mon, 26 Oct 2026 17:01:32 +0100,
Sally Marcher wrote:
>
> Hi,
> patch is attached to this email.
OK, I applied manually now.
thanks,
Takashi
>
> Thanks,
> Sally Marcher
>
> On 10/26/26 2:57 PM, Alexander Tsoy wrote:
> > В Пн, 26/10/2026 в 14:40 +0100, Sally Marcher пишет:
> >> From cd7f80a8beaa40bcb2b313586a3c698d35982c21 Mon Sep 17 00:00:00
> >> 2001
> >> From: Sally Marcher <me@gry.sh>
> >> Date: Mon, 26 Oct 2026 14:29:34 +0100
> >> Subject: [PATCH] Add correct datainterval in the quirks-table for
> >> Microbook II
> >>
> >> This patch fixes playback issues on the Microbook II.
> >> The correct value was in the older driver for this device
> >> (
> >> https://github.com/manuel-rhdt/snd-microbookii/blob/dd304c097bb6a9d522
> >> 76ac29c6969fa02bc7674a/audio.c#L914).
> >>
> >> Datainterval needs to be set explicitly.
> >>
> >> Signed-off-by: Sally Marcher <me@gry.sh>
> >> ---
> >> sound/usb/quirks-table.h | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
> >> index 71444c2898b4..ac7861c3d26c 100644
> >> --- a/sound/usb/quirks-table.h
> >> +++ b/sound/usb/quirks-table.h
> >> @@ -2781,6 +2781,7 @@ YAMAHA_DEVICE(0x7010, "UB99"),
> >> .rates = SNDRV_PCM_RATE_96000,
> >> .ep_attr = USB_ENDPOINT_XFER_ISOC |
> >> USB_ENDPOINT_SYNC_ASYNC,
> >> + .datainterval = 1,
> >> .rate_min = 96000,
> >> .rate_max = 96000,
> >> .nr_rates = 1,
> >> @@ -2803,6 +2804,7 @@ YAMAHA_DEVICE(0x7010, "UB99"),
> >> .rates = SNDRV_PCM_RATE_96000,
> >> .ep_attr = USB_ENDPOINT_XFER_ISOC |
> >> USB_ENDPOINT_SYNC_ASYNC,
> >> + .datainterval = 1,
> >> .rate_min = 96000,
> >> .rate_max = 96000,
> >> .nr_rates = 1,
> > Hi!
> >
> > You should send this path to linux-sound@vger.kernel.org and CC
> > mainterners: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela
> > <perex@perex.cz>
> >
> > Also your email client garbles the patch. For example tabs are replaced
> > by spaces. If you cannot fix that, then it's better to just attach the
> > patch as a text file.
> From cd7f80a8beaa40bcb2b313586a3c698d35982c21 Mon Sep 17 00:00:00 2001
> From: Sally Marcher <me@gry.sh>
> Date: Mon, 26 Oct 2026 14:29:34 +0100
> Subject: [PATCH] Add correct datainterval in the quirks-table for Microbook II
>
> This patch fixes playback issues on the Microbook II.
> The correct value was in the older driver for this device (https://github.com/manuel-rhdt/snd-microbookii/blob/dd304c097bb6a9d52276ac29c6969fa02bc7674a/audio.c#L914).
>
> Datainterval needs to be set explicitly.
>
> Signed-off-by: Sally Marcher <me@gry.sh>
> ---
> sound/usb/quirks-table.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
> index 71444c2898b4..ac7861c3d26c 100644
> --- a/sound/usb/quirks-table.h
> +++ b/sound/usb/quirks-table.h
> @@ -2781,6 +2781,7 @@ YAMAHA_DEVICE(0x7010, "UB99"),
> .rates = SNDRV_PCM_RATE_96000,
> .ep_attr = USB_ENDPOINT_XFER_ISOC |
> USB_ENDPOINT_SYNC_ASYNC,
> + .datainterval = 1,
> .rate_min = 96000,
> .rate_max = 96000,
> .nr_rates = 1,
> @@ -2803,6 +2804,7 @@ YAMAHA_DEVICE(0x7010, "UB99"),
> .rates = SNDRV_PCM_RATE_96000,
> .ep_attr = USB_ENDPOINT_XFER_ISOC |
> USB_ENDPOINT_SYNC_ASYNC,
> + .datainterval = 1,
> .rate_min = 96000,
> .rate_max = 96000,
> .nr_rates = 1,
> --
> 2.56.0
>
next prev parent reply other threads:[~2026-10-27 7:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6690AE3A-5D2A-488D-BB09-1588948491D9@student.tugraz.at>
[not found] ` <abf3bf13-4f91-4026-89ea-74b5f42ea935@student.tugraz.at>
[not found] ` <fc46e94ecb01b6f09ad3548e1654d128d74dea03.camel@tsoy.me>
[not found] ` <1ceb66f2-d5c2-4419-b75f-33afb2f52fbd@student.tugraz.at>
[not found] ` <e79d259f7a3892aba307b3674b235c53b68e1ed3.camel@tsoy.me>
2026-10-26 16:01 ` [PATCH] ALSA: usb-audio: MOTU MicroBook II playback fix Sally Marcher
2026-10-27 7:33 ` Takashi Iwai [this message]
2026-10-27 8:08 ` Alexander Tsoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87qzhb38er.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alexander@tsoy.me \
--cc=linux-sound@vger.kernel.org \
--cc=marcher@student.tugraz.at \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox