From: Takashi Iwai <tiwai@suse.de>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-sound@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH] ALSA: sis7019: Use pcim_iomap_region() for MMIO BAR
Date: Mon, 20 Jul 2026 08:45:20 +0200 [thread overview]
Message-ID: <87qzkyqhvj.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260720000929.1432533-1-rosenp@gmail.com>
On Mon, 20 Jul 2026 02:09:29 +0200,
Rosen Penev wrote:
>
> Replace the open-coded pcim_request_all_regions() +
> devm_ioremap() pair with per-BAR pcim helpers: reserve BAR0 (the
> I/O port region, used via inl/outl) with pcim_request_region(), and
> reserve + iomap BAR1 (MMIO) with a single pcim_iomap_region() call.
>
> This folds the BAR1 reserve and iomap into one managed call. The
> error check moves from a NULL test to IS_ERR(), since pcim_iomap_region()
> returns an IOMEM_ERR_PTR on failure.
>
> Assisted-by: opencode:hy3-free
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
The original code had a fixed BAR size, but let's hope that it was
just a lazy code and not a workaround.
Applied now to for-next branch. Thanks.
Takashi
prev parent reply other threads:[~2026-07-20 6:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 0:09 [PATCH] ALSA: sis7019: Use pcim_iomap_region() for MMIO BAR Rosen Penev
2026-07-20 6:45 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87qzkyqhvj.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rosenp@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox