From: Takashi Iwai <tiwai@suse.de>
To: "Cássio Gabriel" <cassiogabrielcontato@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
Cen Zhang <zzzccc427@gmail.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
notify@kernel.org
Subject: Re: [PATCH] ALSA: pcm: Fix unlocked runtime state reads in xfer ioctls
Date: Sat, 06 Jun 2026 18:18:28 +0200 [thread overview]
Message-ID: <87qzmjskvf.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260605-alsa-pcm-xfer-state-helper-v1-1-eba97cecf820@gmail.com>
On Fri, 05 Jun 2026 17:48:27 +0200,
Cássio Gabriel wrote:
>
> The recent runtime state locking cleanup converted several PCM ioctl state
> checks to snd_pcm_get_state(), including snd_pcm_pre_prepare(),
> snd_pcm_drain() and snd_pcm_kernel_ioctl(). The native and compat xfer
> ioctl paths still sample runtime->state directly before dispatching to the
> PCM transfer helpers, and snd_pcm_common_ioctl() still samples the
> DISCONNECTED state directly in its common precheck.
>
> Use snd_pcm_get_state() for those ioctl-side prechecks as well. This keeps
> the externally visible ioctl entry checks consistent with the stream-locked
> state access used by the recent PCM state-read cleanup.
>
> Fixes: 032322b44c02 ("ALSA: pcm: oss: use proper stream lock for runtime->state access")
> Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Applied to for-next branch now. Thanks.
Takashi
prev parent reply other threads:[~2026-06-06 16:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 15:48 [PATCH] ALSA: pcm: Fix unlocked runtime state reads in xfer ioctls Cássio Gabriel
2026-06-06 16:18 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87qzmjskvf.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=cassiogabrielcontato@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=notify@kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=zzzccc427@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox