public inbox for linux-sound@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Cássio Gabriel" <cassiogabrielcontato@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
	Krzysztof Helt <krzysztof.h1@poczta.fm>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] ALSA: sc6000: fix board configuration state and resume handling
Date: Fri, 10 Apr 2026 08:37:42 +0200	[thread overview]
Message-ID: <87qzongw21.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260410-alsa-sc6000-pm-v1-0-4d9e95493d26@gmail.com>

On Fri, 10 Apr 2026 05:54:31 +0200,
Cássio Gabriel wrote:
> 
> The SC-6000 driver has to program board-level DSP routing before the
> WSS codec can operate correctly. Today that setup has two related
> problems.
> 
> First, the probe path may auto-select IRQ and DMA resources, but the
> SC-6000 soft configuration is still derived from the raw module
> parameter arrays. When irq=auto or dma=auto is used, the WSS codec can
> be created with the selected live resources while the board itself is
> programmed with unresolved values.
> 
> Second, the driver still lacks suspend/resume support. The WSS layer can
> save and restore codec registers, but the SC-6000-specific DSP routing
> and MSS initialization are done only during probe and are not replayed
> after resume.
> 
> This series fixes the probe-time resource mismatch first and then reuses
> that cached board state to restore the hardware on resume. Keeping the
> board programming in a shared helper also keeps the old/new DSP split in
> one place so probe and resume cannot drift apart.
> 
> - Patch 1 stores the computed SC-6000 board state in card-private data and
> builds it from the live resources selected at probe time.
> - Patch 2 wires ISA suspend/resume callbacks and restores the cached
> board setup before the WSS codec resume path runs.
> 
> Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
> ---
> Cássio Gabriel (2):
>       ALSA: sc6000: Keep the programmed board state in card-private data
>       ALSA: sc6000: Restore board setup across suspend

Applied both patches now.  Thanks.


Takashi

      parent reply	other threads:[~2026-04-10  6:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-10  3:54 [PATCH 0/2] ALSA: sc6000: fix board configuration state and resume handling Cássio Gabriel
2026-04-10  3:54 ` [PATCH 1/2] ALSA: sc6000: Keep the programmed board state in card-private data Cássio Gabriel
2026-04-10  3:54 ` [PATCH 2/2] ALSA: sc6000: Restore board setup across suspend Cássio Gabriel
2026-04-10  6:37 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87qzongw21.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=cassiogabrielcontato@gmail.com \
    --cc=krzysztof.h1@poczta.fm \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox