From: Takashi Iwai <tiwai@suse.de>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: jack: Improve string handling in jack_kctl_name_gen
Date: Mon, 26 Jan 2026 09:33:17 +0100 [thread overview]
Message-ID: <87qzrcbwoi.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260125155159.98720-1-thorsten.blum@linux.dev>
On Sun, 25 Jan 2026 16:51:56 +0100,
Thorsten Blum wrote:
>
> If appending " Jack" is not necessary, replace snprintf("%s", ...) with
> the faster strscpy().
>
> Additionally, rename 'need_cat' to the clearer 'append_suf', use local
> variables for the suffix and its length, remove the confusing comment,
> compare strncmp() to 0, and use 'size_t' for the 'size' function
> parameter.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Thanks, applied to for-next branch.
Takashi
prev parent reply other threads:[~2026-01-26 8:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-25 15:51 [PATCH] ALSA: jack: Improve string handling in jack_kctl_name_gen Thorsten Blum
2026-01-26 8:33 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87qzrcbwoi.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=thorsten.blum@linux.dev \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox