Re: [PATCH] In order to get speakers working on ASUS P5405CSA laptop (ID 0x1043, 0x1f63), which are dependent on Cirrus CS3551 smart speaker amplifiers located on SPI bus, I had to add line that applies fixup ALC245_FIXUP_CS35L41_SPI_2 for this system. Fixup enables correct detection of aplifiers and asks for firmware files (which are available in official sound card drivers for Windows from Cirrus).

[Takashi Iwai <tiwai@suse.de>]

On Wed, 26 Feb 2025 15:33:49 +0100,
Daniel Bárta wrote:
> 
> Signed-off-by: Daniel Bárta <daniel.barta@trustlab.cz>

Could you fix the patch in a proper format and resubmit?
Namely, instead of putting all texts in the Subject line, give a
proper subject (e.g. "[PATCH] ALSA: hda: Fix speakers on ASUS
P5405CSA"), then put more patch descriptions in the body, finally put
your Signed-off-by.

Also, let's put patches@opensource.cirrus.com to Cc, so that they can
verify whether the added quirk for Cirrus code is correct.


thanks,

Takashi

> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 224616fbec4f..360131dd2d06 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -10699,6 +10699,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1043, 0x1f12, "ASUS UM5302", ALC287_FIXUP_CS35L41_I2C_2),
>  	SND_PCI_QUIRK(0x1043, 0x1f1f, "ASUS H7604JI/JV/J3D", ALC245_FIXUP_CS35L41_SPI_2),
>  	SND_PCI_QUIRK(0x1043, 0x1f62, "ASUS UX7602ZM", ALC245_FIXUP_CS35L41_SPI_2),
> +	SND_PCI_QUIRK(0x1043, 0x1f63, "ASUS P5405CSA", ALC245_FIXUP_CS35L41_SPI_2),
>  	SND_PCI_QUIRK(0x1043, 0x1f92, "ASUS ROG Flow X16", ALC289_FIXUP_ASUS_GA401),
>  	SND_PCI_QUIRK(0x1043, 0x3030, "ASUS ZN270IE", ALC256_FIXUP_ASUS_AIO_GPIO2),
>  	SND_PCI_QUIRK(0x1043, 0x31d0, "ASUS Zen AIO 27 Z272SD_A272SD", ALC274_FIXUP_ASUS_ZEN_AIO_27),
> -- 
> 2.47.2
>