Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Ethan Carter Edwards <ethan@ethancedwards.com>
Cc: perex@perex.cz, tiwai@suse.com, arnd@arndb.de,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	ryan_richards@creativelabs.com, wychay@ctl.creative.com
Subject: Re: [PATCH] ALSA: ctxfi: Simplify dao_clear_{left,right}_input() functions
Date: Mon, 30 Dec 2024 11:54:48 +0100	[thread overview]
Message-ID: <87r05pwidj.wl-tiwai@suse.de> (raw)
In-Reply-To: <vxs3fuzdia52pcztueh7g3vug3mgl4s35p3yfwqjz3xh2kdmof@ib4s63vadpwk>

On Mon, 30 Dec 2024 06:06:47 +0100,
Ethan Carter Edwards wrote:
> 
> There was a lote of code duplication in the dao_clear_left_input() and
> dao_clear_right_input() functions. A new function, dao_clear_input(),
> was created and now the left and right functions call it instead of
> repeating themselves.
> 
> Link: https://lore.kernel.org/lkml/NyKCr2VHK_xCQDwNxFKKx2LVd2d_AC2f2j4eAvnD9uRPtb50i2AruCLOp6mHxsGiyYJ0Tgd3Z50Oy1JTi5gPhjd2WQM2skrv7asp3fLl8HU=@ethancedwards.com/
> 
> Signed-off-by: Ethan Carter Edwards <ethan@ethancedwards.com>
> Co-developed-by: David Laight <david.laight.linux@gmail.com>

The submitted patch isn't cleanly applicable.  Possibly due to your
mailer setup.

Could you try to resubmit via git-send-email?


thanks,

Takashi

      reply	other threads:[~2024-12-30 10:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-30  5:06 [PATCH] ALSA: ctxfi: Simplify dao_clear_{left,right}_input() functions Ethan Carter Edwards
2024-12-30 10:54 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r05pwidj.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=arnd@arndb.de \
    --cc=ethan@ethancedwards.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=ryan_richards@creativelabs.com \
    --cc=tiwai@suse.com \
    --cc=wychay@ctl.creative.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox