From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60DE21BB for ; Mon, 27 Nov 2023 08:21:42 -0800 (PST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DD2D81FC07; Mon, 27 Nov 2023 16:21:40 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9AFCB1379A; Mon, 27 Nov 2023 16:21:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id 1m9kJBTCZGWDWQAAD6G6ig (envelope-from ); Mon, 27 Nov 2023 16:21:40 +0000 Date: Mon, 27 Nov 2023 17:21:40 +0100 Message-ID: <87r0kbnp4b.wl-tiwai@suse.de> From: Takashi Iwai To: Peter Ujfalusi Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, pierre-louis.bossart@linux.intel.com, kai.vehmanen@linux.intel.com, ranjani.sridharan@linux.intel.com Subject: Re: [PATCH] ALSA: hda: intel-nhlt: Ignore vbps when looking for DMIC 32 bps format In-Reply-To: <20231127111658.17275-1-peter.ujfalusi@linux.intel.com> References: <20231127111658.17275-1-peter.ujfalusi@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Level: Authentication-Results: smtp-out2.suse.de; none X-Rspamd-Server: rspamd2 X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Spam-Score: -4.00 X-Rspamd-Queue-Id: DD2D81FC07 On Mon, 27 Nov 2023 12:16:58 +0100, Peter Ujfalusi wrote: > > When looking up DMIC blob from the NHLT table and the format is 32 bits, > ignore the vbps matching for 32 bps for DMIC since some NHLT table have > the vbps as 24, some have it as 32. > The DMIC hardware supports only one type of 32 bit sample size, which is > 24 bit sampling on the MSB side and bits[1:0] is used for indicating the > channel number. > > Signed-off-by: Peter Ujfalusi > Reviewed-by: Kai Vehmanen > Reviewed-by: Pierre-Louis Bossart > Reviewed-by: Ranjani Sridharan Thanks, applied now to for-linus branch. Takashi