Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Zak Brighton Knight <zakbrightonknight@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
	linux-sound@vger.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Skip probe-time interface setup for MSI MAG X570S ALC4080
Date: Tue, 27 Oct 2026 08:29:11 +0100	[thread overview]
Message-ID: <87se1r38l4.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261026140934.3575940-1-zakbrightonknight@gmail.com>

On Mon, 26 Oct 2026 15:09:34 +0100,
Zak Brighton Knight wrote:
> 
> The Realtek ALC4080 USB audio on the MSI MAG X570S Tomahawk Max WiFi
> (USB ID 0db0:a073, the same ID as the MAG X570S Torpedo Max mixer map)
> has six streaming interfaces with 68 altsettings in total. For each of
> them, __snd_usb_parse_audio_interface() switches the interface to alt 0,
> initialises pitch and the sample rate and switches back, which costs
> about 64 ms per altsetting here, mostly spent inside usb_set_interface().
> Probing the card therefore takes about 6.4 seconds, on every boot.
> 
> That setup is redundant with snd_usb_endpoint_prepare() at stream-open
> time, so set QUIRK_FLAG_SKIP_IFACE_SETUP for this device.
> 
> Tested on 7.2.11 with the equivalent quirk_flags=0db0:a073:skip_iface_setup
> module option, re-probing the device via its sysfs "authorized"
> attribute: probe time went from 6.45 s to 0.57 s, all 68 altsettings
> are still listed in /proc/asound/cardX/stream*, and playback and
> capture work.
> 
> Assisted-by: LLM
> Signed-off-by: Zak Brighton Knight <zakbrightonknight@gmail.com>

Applied now.  Thanks.


Takashi

      reply	other threads:[~2026-10-27  7:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 14:09 [PATCH] ALSA: usb-audio: Skip probe-time interface setup for MSI MAG X570S ALC4080 Zak Brighton Knight
2026-10-27  7:29 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87se1r38l4.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=zakbrightonknight@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox