From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCA8A7E779 for ; Fri, 23 Feb 2024 13:57:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708696667; cv=none; b=nx25RBP9j7JTZKNAGKIGjpSiqi8d0BwnBkmkO8zC+n5oN6mPXVAwgcCA7DYFWwjUtZN0ZSd0ZnfEf2bsish1+kM7RToGkyrjF5pw/Ek4CdnfG3vmziGWnwFqFUlSl0IpYEh57RA2+PQqq7DaQWfg6hTlSFo/XnM7FN3nYrfMYV0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708696667; c=relaxed/simple; bh=xaO4cUScFrSD4pTs/VF4FjHkzV69WCYv1eyYZyogaag=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=MgUm8rXx2a//kRO60bhJAXtt9U8edvcAl1W9/9tjEZOGRPXNoX/5lPaoHwjgQHnNENq1tNRJv83IgVZcYC4CS14N167/fMMmzTPoOlmuTQd7IRPWvsRZ639Nr5S2Aiwm+e6ZGpfxhfoGOrlr/p2znxlSmEllPznYgpaacK6yjik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=BplvIKk+; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=6BUBAebZ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=UDw2Hkg/; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=NsPt6L+L; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="BplvIKk+"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="6BUBAebZ"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="UDw2Hkg/"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="NsPt6L+L" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EB59D21228; Fri, 23 Feb 2024 13:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708696664; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V2VnXiwBMr8OEGNfOOEISrIRVqyNDwzg6Yi1yiJ6y0k=; b=BplvIKk+ejYyXBCvNq3pwruGLaaPmqdSTY672Ro0Z2fHVuHO3PHMVBGbflUa3RaLTjx5U5 dp57nWhedA5bCpLe5CdP/K3rMv5u/XrZWU1AnIKbgcqDcfDuFTLN5/fplwHn83Qe4UzylK 7Fy/GD+IZISbuMmPlhpONAa5G3ww2FU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708696664; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V2VnXiwBMr8OEGNfOOEISrIRVqyNDwzg6Yi1yiJ6y0k=; b=6BUBAebZ6+9gidjUaXigSgp3mYqrqFZkq5uNE4/Z+xB1eG99ih36C5W4kiJ4l3rVTmdMnj MtdNPveetwF/MAAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708696663; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V2VnXiwBMr8OEGNfOOEISrIRVqyNDwzg6Yi1yiJ6y0k=; b=UDw2Hkg/L+Gn0/o/DaJP2u5bkdWaWfXqX3Sjryb4hPilgT5aTF2zungS3bWHejOuU4FtcM eykc4d/nyjieflb+eTVbaCgQHeI7c2U9Nyd2/8Oe4hB/XgYv14MwsYsdxveP0SKRO6+BYP iGxYTWoSEJZRLBkBsTSqKkEjUt1kM3k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708696663; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V2VnXiwBMr8OEGNfOOEISrIRVqyNDwzg6Yi1yiJ6y0k=; b=NsPt6L+L3H8lwvCuJ/eFnghQ3Y3WyLMpOTV6bcJ9tsLa+px1PUP6NVgF5cI80Tef1JCxyO miy7s1nigjDq2CBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C6875132C7; Fri, 23 Feb 2024 13:57:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id +WXyLlek2GUnDAAAD6G6ig (envelope-from ); Fri, 23 Feb 2024 13:57:43 +0000 Date: Fri, 23 Feb 2024 14:57:43 +0100 Message-ID: <87sf1j2sh4.wl-tiwai@suse.de> From: Takashi Iwai To: Gergo Koteles Cc: linux-sound@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: PCI SSID and Codec SSID collision? In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -0.75 X-Spamd-Result: default: False [-0.75 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; SUBJECT_ENDS_QUESTION(1.00)[]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-1.45)[91.29%] X-Spam-Flag: NO On Fri, 23 Feb 2024 13:05:12 +0100, Gergo Koteles wrote: > > Hi, > > The Lenovo Yoga Slim Pro 9 14IRP8 has tas2781 amplifiers, but it can > only pickup its fixup with the hda_model=17aa:38be module parameter. > > The 17aa:38be is the SSID of its Codec. The PCI SSID is 17aa:3802. > > The patch_realtek.c has these fixup: > SND_PCI_QUIRK(0x17aa, 0x3802, "Lenovo Yoga DuetITL 2021", > ALC287_FIXUP_YOGA7_14ITL_SPEAKERS), > SND_PCI_QUIRK(0x17aa, 0x38be, "Yoga S980-14.5 proX YC Dual", > ALC287_FIXUP_TAS2781_I2C), > > And the snd_hda_pick_fixup() picks the former fixup because of the same > PCI SSID, but that is a Codec SSID? > > At least it worked without that line. > https://bugzilla.kernel.org/show_bug.cgi?id=208555#c839 > > It would be nice if it can be work without the module parameter. > > What is the best way to add this strangeness to patch_realtek.c? That's a bad collision that happens rarely but more than once... In this case, we'd need to fix 17aa:3802 matching to be a special function that checks the model more closely. e.g. create a quirk function that checks the codec SSID additionally and apply the different quirks from there. thanks, Takashi