From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="adTiBlcs"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="4LbUf3uo"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="adTiBlcs"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="4LbUf3uo" Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F07D0109 for ; Thu, 14 Dec 2023 00:49:31 -0800 (PST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4DCAE21F4B; Thu, 14 Dec 2023 08:49:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702543770; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hPGF7C63QnLMDdqrES6sWHt5bBSQu60mKg48x6FHnmQ=; b=adTiBlcsi8BsbK34WVECh+BltTltgXZlGoBOi1qzEElU6jLAFqGL3A/eDznHxkuxivl+qq voLgWZFvsOHWoe5u8iavzg5PfsHOaufnHFaBrR/CJFYq84iV99af0kpuviELKhldUZnf8Q kZgZsY6NCvJM0xg2PEYx5USw7hmhIoc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702543770; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hPGF7C63QnLMDdqrES6sWHt5bBSQu60mKg48x6FHnmQ=; b=4LbUf3uoIv3nqwpUwBEUmGQWcNglnPjw1orMiKe2ZEHTUl2jSX7aIJpm6+aCcK99E8QL4i ye2iwkdJ67GLgoBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702543770; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hPGF7C63QnLMDdqrES6sWHt5bBSQu60mKg48x6FHnmQ=; b=adTiBlcsi8BsbK34WVECh+BltTltgXZlGoBOi1qzEElU6jLAFqGL3A/eDznHxkuxivl+qq voLgWZFvsOHWoe5u8iavzg5PfsHOaufnHFaBrR/CJFYq84iV99af0kpuviELKhldUZnf8Q kZgZsY6NCvJM0xg2PEYx5USw7hmhIoc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702543770; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hPGF7C63QnLMDdqrES6sWHt5bBSQu60mKg48x6FHnmQ=; b=4LbUf3uoIv3nqwpUwBEUmGQWcNglnPjw1orMiKe2ZEHTUl2jSX7aIJpm6+aCcK99E8QL4i ye2iwkdJ67GLgoBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 173C9137E8; Thu, 14 Dec 2023 08:49:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id UPzcA5rBemVLPgAAD6G6ig (envelope-from ); Thu, 14 Dec 2023 08:49:30 +0000 Date: Thu, 14 Dec 2023 09:49:29 +0100 Message-ID: <87sf45qicm.wl-tiwai@suse.de> From: Takashi Iwai To: =?ISO-8859-1?Q?Cl=E9ment?= Villeret Cc: linux-sound@vger.kernel.org, tiwai@suse.com, perex@perex.cz Subject: Re: ALSA: hda/realtek: Add quirk for ASUS ROG GV302XA In-Reply-To: <446e6c6d-f639-4576-804a-e64e3fa4c463@gmail.com> References: <446e6c6d-f639-4576-804a-e64e3fa4c463@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: 11.71 X-Spam-Level: *********** X-Spamd-Result: default: False [-5.50 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; DWL_DNSWL_BLOCKED(0.00)[suse.de:dkim]; R_SPF_SOFTFAIL(0.00)[~all:c]; RCVD_COUNT_THREE(0.00)[3]; MX_GOOD(-0.01)[]; DKIM_TRACE(0.00)[suse.de:+]; DMARC_POLICY_ALLOW(0.00)[suse.de,none]; NEURAL_HAM_SHORT(-0.19)[-0.972]; DMARC_POLICY_ALLOW_WITH_FAILURES(-0.50)[]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-0.00)[23.70%]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; WHITELIST_DMARC(-7.00)[suse.de:D:+]; MID_CONTAINS_FROM(1.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; SUSPICIOUS_RECIPS(1.50)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Level: X-Rspamd-Queue-Id: 4DCAE21F4B X-Spam-Score: -5.50 X-Spam-Flag: NO Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=adTiBlcs; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4LbUf3uo; dmarc=pass (policy=none) header.from=suse.de; spf=softfail (smtp-out1.suse.de: 2a07:de40:b281:104:10:150:64:97 is neither permitted nor denied by domain of tiwai@suse.de) smtp.mailfrom=tiwai@suse.de On Wed, 13 Dec 2023 20:36:09 +0100, Clément Villeret wrote: > > > Asus ROG Flowx13 (GV302XA) seems require same patch as others asus products > > Signed-off-by: Clément Villeret Now better, but... > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > > index 0377912e9264..eb9f617b6273 100644 > > --- a/sound/pci/hda/patch_realtek.c > > +++ b/sound/pci/hda/patch_realtek.c > > @@ -9953,6 +9953,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > > SND_PCI_QUIRK(0x1043, 0x1483, "ASUS GU603V", ALC285_FIXUP_ASUS_HEADSET_MIC), > > SND_PCI_QUIRK(0x1043, 0x1493, "ASUS GV601V", ALC285_FIXUP_ASUS_HEADSET_MIC), (snip) The lines above are weirdly formatted with extra line feeds. Try the following before resubmission: - Send the patch to yourself, save the mail content - Apply the mail content via "git am" command - If this works, it's a correct patch; then submit to the public ML Also, note that you'd need to put a blank line before Signed-off-by line. thanks, Takashi