From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7035EC197A0 for ; Fri, 17 Nov 2023 13:32:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231179AbjKQNcU (ORCPT ); Fri, 17 Nov 2023 08:32:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjKQNcT (ORCPT ); Fri, 17 Nov 2023 08:32:19 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A65DD57; Fri, 17 Nov 2023 05:32:16 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AF30C1F38D; Fri, 17 Nov 2023 13:32:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1700227934; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v9hbRLCFAF0MFU6V5KRjF2Qo9Ot751dxw2RqL6OaPeA=; b=CB6G0qkDUwa00UbK3T+SjtyL7Lhu1yBHD3ws2DlrFL0KNhirbUaANdS3hP6AaxTjN+mKsj 5SH45CWTehWYkqMr92BXWXkvWGctxvo6w7VgZJkmHlXZ+uahkw4uxMuczexFisD8NGXVpt /kJGaJCjkXsPiReKs+eu+WqgoGNNaHg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1700227934; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v9hbRLCFAF0MFU6V5KRjF2Qo9Ot751dxw2RqL6OaPeA=; b=TX4Q8KFNL7ErbepzZMrKkeXSdejFmjVv0FnhTiJicd47aMqqQ0WFVnd7bLW2h4GY2v3Mlt yADE7BR0lhkFjoAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 788A51341F; Fri, 17 Nov 2023 13:32:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id OVWBHF5rV2WKWAAAMHmgww (envelope-from ); Fri, 17 Nov 2023 13:32:14 +0000 Date: Fri, 17 Nov 2023 14:32:14 +0100 Message-ID: <87sf54jyjl.wl-tiwai@suse.de> From: Takashi Iwai To: Oliver Sieber Cc: Bagas Sanjaya , Linux Kernel Mailing List , Linux Sound System , Linux ALSA Development , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Subject: Re: Fwd: acp3x: Missing product ID for Thinkpad T14s Gen2 AMD Ryzen 7 PRO 5850U In-Reply-To: <78149e00-12b5-459b-8754-a17dd974916d@gmail.com> References: <8bd0e77f-720b-4804-bbd8-477bd7df938e@gmail.com> <251c1bea-8250-40dd-bdea-1cd739d1e77a@gmail.com> <78149e00-12b5-459b-8754-a17dd974916d@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [-7.23 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; BAYES_HAM(-3.00)[100.00%]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.13)[-0.628]; RCPT_COUNT_SEVEN(0.00)[9]; MID_CONTAINS_FROM(1.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[gmail.com,vger.kernel.org,alsa-project.org,kernel.org,perex.cz,suse.com]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Precedence: bulk List-ID: X-Mailing-List: linux-sound@vger.kernel.org On Fri, 17 Nov 2023 08:17:48 +0100, Oliver Sieber wrote: > > > Hi, > > in the following I provide my proposed patch for the bug report on Bugzilla > [1]. Let me quote from it: > > Hey,sound/soc/amd/renoir/rn-pci-acp3x.c has a hard-coded list of quirks. It seems like some product IDs may be missing. In my case, I am using a Lenovo Thinkpad t14s gen2 with an AMD Ryzen 7 PRO 5850U. > My audio output is fine but my internal microphone cannot be found. > > Running `dmidecode` yields: > > Handle 0x000F, DMI type 1, 27 bytes > System Information > Manufacturer: LENOVO > Product Name: 20XGS1KT02 > Version: ThinkPad T14s Gen 2a > > Could it be that one may have to add the product ID "20XGS1KT02" to the hard-coded list of quirks in rn-pci-acp3x.c? > > It seems as there have been similar problems in the past, e.g. https://bugzilla.kernel.org/show_bug.cgi?id=216270. > > My proposed diff looks as follows: > > diff --git a/sound/soc/amd/renoir/rn-pci-acp3x.c b/sound/soc/amd/renoir/ > rn-pci-acp3x.c > index b3812b70f5f9..754e24d55e6f 100644 > --- a/sound/soc/amd/renoir/rn-pci-acp3x.c > +++ b/sound/soc/amd/renoir/rn-pci-acp3x.c > @@ -199,6 +199,13 @@ static const struct dmi_system_id rn_acp_quirk_table[] = > { >              DMI_EXACT_MATCH(DMI_BOARD_NAME, "20NLCTO1WW"), >          } >      }, > +    { > +        /* Lenovo ThinkPad T14s Gen 2 */ > +        .matches = { > +            DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "LENOVO"), > +            DMI_EXACT_MATCH(DMI_BOARD_NAME, "20XGS1KT02"), > +        } > +    }, >      {} >  }; > > Please have in mind that this is my first patch for the kernel. The kernel patch should be in a proper format, so that it can be merged to the upstream. e.g. The Subject line should have a brief description with the proper prefix for the corresponding subsystem (in your case, something like "ASoC: amd:"). It'll follow the patch description, as well as your proper Signed-off-by tag. The details are found in https://docs.kernel.org/process/submitting-patches.html Could you resubmit the patch in a proper format? thanks, Takashi