Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Zhang Heng <zhangheng@kylinos.cn>
Cc: Takashi Iwai <tiwai@suse.de>,
	Gordon Chen <chengordon326@gmail.com>,
	perex@perex.cz, tiwai@suse.com, kees@kernel.org,
	jussi@sonarnerd.net, hulianqin@vivo.com, i@rong.moe, g@b4.vu,
	cryolitia@uniontech.com, pav@iki.fi, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb-audio: Fix boot-time crackling for Generic USB Audio device
Date: Mon, 20 Jul 2026 08:39:17 +0200	[thread overview]
Message-ID: <87tspuqi5m.wl-tiwai@suse.de> (raw)
In-Reply-To: <9fc3da84-0985-4357-93bb-ce90a86b01de@kylinos.cn>

On Mon, 20 Jul 2026 04:23:25 +0200,
Zhang Heng wrote:
> 
> 
> > Please add some comment why the device needs this workaround.
> > IIUC, the reason is different from the others in your case.
> > 
> > Also, please verify that the problem is reproduced in the latest
> > upstream kernel, and the workaround works as expected there, too.
> > 
> > 
> > thanks,
> > 
> > Takashi
> 
> >> --- a/sound/usb/quirks.c
> >> +++ b/sound/usb/quirks.c
> >> @@ -1938,6 +1938,10 @@ void snd_usb_endpoint_start_quirk(struct
> snd_usb_endpoint *ep)
> >>   	    ep->type == SND_USB_ENDPOINT_TYPE_SYNC)
> >>   		ep->skip_packets = 4;
> >>
> >> +	if (ep->chip->usb_id == USB_ID(0x1e0b, 0xd01e) &&
> >> +	    ep->type == SND_USB_ENDPOINT_TYPE_SYNC)
> >> +		ep->skip_packets = 4;
> >> +
> 
> Let me update the current status: that piece of code can be
> omitted. I have applied your test patch, but there is no
> change. It might be that your patch has no effect on this
> device. I tested with version v7.2-rc1. To be honest,
> without any modification, the problem becomes a reproducible
> stutter plus crackling noise. After applying my fix, it
> becomes a probabilistic stutter (still with a relatively
> high probability of recurrence), but when there is no
> stutter, there is also no crackling noise. So I am sure
> that this patch is at least useful, but it does not
> perfectly solve the problem. I am still trying to resolve
> the stutter issue, and I wonder if it is due to resource
> contention during boot? This problem only occurs at boot
> time; after entering the system, it disappears.

OK, if the workaround is no solid solution, it's not worth to take.

Have you tried lowlatency=0 option?  If it's an implicit fb and about
the playback, it might stabilize.


thanks,

Takashi

  reply	other threads:[~2026-07-20  6:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-13  8:10 [PATCH] usb-audio: Fix boot-time crackling for Generic USB Audio device Zhang Heng
2026-07-13 13:20 ` Gordon Chen
2026-07-13 15:05   ` Takashi Iwai
2026-07-14 13:09     ` Zhang Heng
2026-07-19  8:54       ` Takashi Iwai
2026-07-20  2:23         ` Zhang Heng
2026-07-20  6:39           ` Takashi Iwai [this message]
2026-07-20  9:34             ` Zhang Heng
2026-07-20  9:40             ` Zhang Heng
2026-07-20  9:58             ` Zhang Heng
2026-07-14  1:58   ` Zhang Heng
2026-07-14  7:40     ` Takashi Iwai
2026-07-14 13:02       ` Zhang Heng
2026-07-14 13:38         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tspuqi5m.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=chengordon326@gmail.com \
    --cc=cryolitia@uniontech.com \
    --cc=g@b4.vu \
    --cc=hulianqin@vivo.com \
    --cc=i@rong.moe \
    --cc=jussi@sonarnerd.net \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=pav@iki.fi \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=zhangheng@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox