From: Takashi Iwai <tiwai@suse.de>
To: "Cássio Gabriel" <cassiogabrielcontato@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: i2c: ak4xxx-adda: implement AK4529 reset handling
Date: Wed, 08 Apr 2026 10:51:48 +0200 [thread overview]
Message-ID: <87tstlltqz.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260407-ak4529-reset-handling-v1-1-b971c18b1a32@gmail.com>
On Tue, 07 Apr 2026 23:13:06 +0200,
Cássio Gabriel wrote:
>
> Delta 410 uses snd_akm4xxx_reset() both around DFS changes and from
> its PM callbacks, but the AK4529 case in this helper is still left
> unimplemented and never drives the codec reset path.
>
> The AK4529 datasheet documents register 09h.RSTN as an internal
> timing reset. Clearing RSTN powers down the ADC and DAC blocks, but
> does not reinitialize the register map. That matches the existing
> ak4xxx helper model, which already keeps the desired codec state in
> the software register cache.
>
> Implement AK4529 reset handling by clearing 09h.RSTN on state == 1,
> then replaying the cached register image and setting RSTN back to 1
> on state == 0.
>
> This restores cached Delta 410 mixer state after resume and gives
> the AK4529 DFS-change path a real codec reset sequence.
>
> Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Applied to for-next branch. Thanks.
Takashi
prev parent reply other threads:[~2026-04-08 8:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 21:13 [PATCH] ALSA: i2c: ak4xxx-adda: implement AK4529 reset handling Cássio Gabriel
2026-04-08 8:51 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tstlltqz.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=cassiogabrielcontato@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox