Re: [PATCH 1/2] ALSA: aoa/onyx: Fix OF node leak on probe failure

[Takashi Iwai <tiwai@suse.de>]

On Thu, 02 Apr 2026 04:35:41 +0200,
wangdich9700@163.com wrote:
> 
> From: wangdicheng <wangdicheng@kylinos.cn>
> 
> Add missing of_node_put() in the error path.
> 
> Signed-off-by: wangdicheng <wangdicheng@kylinos.cn>
> ---
>  sound/aoa/codecs/onyx.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/aoa/codecs/onyx.c b/sound/aoa/codecs/onyx.c
> index 04961c456d2c..fea12d3a06a9 100644
> --- a/sound/aoa/codecs/onyx.c
> +++ b/sound/aoa/codecs/onyx.c
> @@ -985,6 +985,7 @@ static int onyx_i2c_probe(struct i2c_client *client)
>  	printk(KERN_DEBUG PFX "created and attached onyx instance\n");
>  	return 0;
>   fail:
> +	of_node_put(onyx->codec.node);
>  	kfree(onyx);
>  	return -ENODEV;

This error path is used commonly for the code path before
of_node_get(), hence you can't put of_node_put() unconditionally.

You'll need another goto label for of_node_put() and the error path
from aoa_codec_register() should jump to it.


thanks,

Takashi