From: Takashi Iwai <tiwai@suse.de>
To: Sergey Shtylyov <s.shtylyov@auroraos.dev>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
<linux-sound@vger.kernel.org>,
Mathieu Bouffard <mbouffard@strangequarks.org>
Subject: Re: [PATCH] ALSA: usb-audio: fix broken logic in snd_audigy2nx_led_update()
Date: Tue, 03 Feb 2026 18:15:08 +0100 [thread overview]
Message-ID: <87tsvxkaub.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260203161558.18680-1-s.shtylyov@auroraos.dev>
On Tue, 03 Feb 2026 17:15:57 +0100,
Sergey Shtylyov wrote:
>
> When the support for the Sound Blaster X-Fi Surround 5.1 Pro was added,
> the existing logic for the X-Fi Surround 5.1 in snd_audigy2nx_led_put()
> was broken due to missing *else* before the added *if*: snd_usb_ctl_msg()
> became incorrectly called twice and an error from first snd_usb_ctl_msg()
> call ignored. As the added snd_usb_ctl_msg() call was totally identical
> to the existing one for the "plain" X-Fi Surround 5.1, just merge those
> two *if* statements while fixing the broken logic...
>
> Found by Linux Verification Center (linuxtesting.org) with the Svace static
> analysis tool.
>
> Fixes: 7cdd8d73139e ("ALSA: usb-audio - Add support for USB X-Fi S51 Pro")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@auroraos.dev>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2026-02-03 17:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 16:15 [PATCH] ALSA: usb-audio: fix broken logic in snd_audigy2nx_led_update() Sergey Shtylyov
2026-02-03 17:15 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tsvxkaub.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-sound@vger.kernel.org \
--cc=mbouffard@strangequarks.org \
--cc=perex@perex.cz \
--cc=s.shtylyov@auroraos.dev \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox