From: Takashi Iwai <tiwai@suse.de>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: <broonie@kernel.org>, <tiwai@suse.com>,
<linux-sound@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>
Subject: Re: [PATCH v2 0/3] ASoC: Use snd_ctl_find_id_mixer() instead of open-coding
Date: Tue, 02 Apr 2024 08:41:02 +0200 [thread overview]
Message-ID: <87ttkks1vl.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240401100210.61277-1-rf@opensource.cirrus.com>
On Mon, 01 Apr 2024 12:02:07 +0200,
Richard Fitzgerald wrote:
>
> The first two patches change snd_soc_card_get_kcontrol() to use the
> core snd_ctl_find_id_mixer() functionality instead of open-coding its
> own list walk.
>
> The last patch adds a KUnit test for this, which was tested on the
> original and modified code.
>
> Changes in V2:
> Only change is in the KUnit test (patch #3) to make the const strings
> more consty.
>
> Richard Fitzgerald (3):
> ALSA: control: Introduce snd_ctl_find_id_mixer_locked()
> ASoC: soc-card: Use snd_ctl_find_id_mixer() instead of open-coding
> ASoC: soc-card: Add KUnit test case for snd_soc_card_get_kcontrol
I suppose this goes via Mark's tree. Feel free to take my ack:
Reviewed-by: Takashi Iwai <tiwai@suse.de>
thanks,
Takashi
next prev parent reply other threads:[~2024-04-02 6:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 10:02 [PATCH v2 0/3] ASoC: Use snd_ctl_find_id_mixer() instead of open-coding Richard Fitzgerald
2024-04-01 10:02 ` [PATCH v2 1/3] ALSA: control: Introduce snd_ctl_find_id_mixer_locked() Richard Fitzgerald
2024-04-01 10:02 ` [PATCH v2 2/3] ASoC: soc-card: Use snd_ctl_find_id_mixer() instead of open-coding Richard Fitzgerald
2024-04-01 10:02 ` [PATCH v2 3/3] ASoC: soc-card: Add KUnit test case for snd_soc_card_get_kcontrol Richard Fitzgerald
2024-04-02 6:41 ` Takashi Iwai [this message]
2024-04-02 23:29 ` [PATCH v2 0/3] ASoC: Use snd_ctl_find_id_mixer() instead of open-coding Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttkks1vl.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox