Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: william <assassinshalo29@gmail.com>
Cc: linux-sound@vger.kernel.org, tiwai@suse.de, evgeny@devduty.com,
	stable@vger.kernel.org, regressions@lists.linux.dev
Subject: Re: [REGRESSION] ALSA: hda/realtek: no speaker sound on Lenovo Legion 16IRX9H since f2293e7b2ddd (PCI SSID 17aa:3842 shared with ThinkBook X G2 IAH)
Date: Tue, 17 Nov 2026 10:10:16 +0100	[thread overview]
Message-ID: <87v75vzuvb.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAFjFWEjt+DPJ_gM1uTBZ_NoV6-3mi57ArjZ_Qdah2DqY-GCD1w@mail.gmail.com>

On Mon, 16 Nov 2026 02:24:00 +0100,
william wrote:
> 
> Hi,
> Commit f2293e7b2ddd ("ALSA: hda/realtek: Enable all four speaker amps on Lenovo
> ThinkBook X G2 IAH", Cc: stable) matches the laptop by PCI SSID
> 17aa:3842, on the
> assumption that this SSID had no quirk entry. The Lenovo Legion 16IRX9H (83DE)
> has the same PCI SSID, so its internal speakers are silent on kernels that carry
> this commit. Headphones work.
> Hardware
> Lenovo Legion 16IRX9H, product 83DE, BIOS N2CN32WW
> Codec: Realtek ALC287, codec SSID 17aa:38cd, PCI SSID 17aa:3842
> Amplifier: ACPI TIAS2781:00 (i2c-TIAS2781:00 on i2c_designware.2),
> driver snd_hda_scodec_tas2781_i2c
> Kernels
> Works: 7.2.10-200.nobara.fc44, 7.1.6-1-cachyos (live ISO)
> Fails: 7.3.4-201.nobara.fc44, 7.3.4-1-cachyos
> The 3842 entry is absent from v7.2 and v7.3, present in v7.3.4, and still
> present in v7.4-rc1 and master as of 2026-11-15 (checked via the GitHub mirror).
> Analysis
> snd_hda_pick_fixup() walks the table and matches PCI-SSID entries before the
> codec-SSID fallback. Before the commit, 17aa:3842 had no entry, so this machine
> fell through to the existing codec-SSID entry
> SND_PCI_QUIRK(0x17aa, 0x38cd, "Y790 VECO DUAL", ALC287_FIXUP_TAS2781_I2C),
> which works. With the commit, the 3842 entry wins and chains to
> cs35l41_fixup_i2c_four(), so the codec master waits for four CS35L41 components
> that do not exist on this machine.
> Evidence on 7.3.4
> dmesg: "ALC287: picked fixup for PCI SSID 17aa:3842"; no "bound i2c-TIAS2781:00"
> line (on 7.2.10 that line is present).
> /sys/kernel/debug/device_component/hdaudioC0D0: master "not bound",
> four entries "(unknown) not registered".
> With dyndbg, after "echo 1 > /sys/class/sound/hwC0D0/reconfig":
> hdaudioC0D0: trying to bring up adev
> hdaudioC0D0: Looking for component 0
> hdaudioC0D0: master has incomplete components
> After unbinding/binding i2c-TIAS2781:00, tas2781-hda logs "adding component"
> but the master still reports incomplete components.
> Workaround confirmed
> Booting with snd_hda_intel.model=17aa:38cd (alias SSID, handled first by the
> picker) gives:
> ALC287: picked fixup for alias SSID 17aa:38cd
> bound i2c-TIAS2781:00 (ops tas2781_hda_comp_ops [snd_hda_scodec_tas2781_i2c])
> and the speakers work.
> Possible direction
> Since both laptops share the PCI SSID, the ThinkBook entry cannot be fixed by
> PCI SSID alone. One option is a codec-SSID entry for this machine placed before
> the 0x3842 line, e.g.
> HDA_CODEC_QUIRK(0x17aa, 0x38cd, "Legion 16IRX9H / Y790 VECO DUAL",
> ALC287_FIXUP_TAS2781_I2C),
> I have not compiled or tested a patch, only the model= alias above. I am happy
> to test patches on this hardware.
> Separate observation
> After the workaround, speakers still stopped after some idle time. It went away
> with snd_hda_intel power_save=0 power_save_controller=N and keeping
> i2c-TIAS2781:00 power/control at "on". I applied both at once, so I do not know
> which is required. This looks unrelated to the regression above.
> 
> I'd really appreciate it if the issue is fixed, as I'm now having the
> same problem when the laptop is turned on after being suspended for a
> while, and I haven't been able to solve it.

Thanks for the report.  Could you verify whether the patch below is
what you've tested?  I left Y790 entry as is because it's not 100%
sure whether it has also the same codec SSID.


thanks,

Takashi

-- 8< --
Subject: [PATCH] ALSA: hda/realtek: Fix regression on Lenovo Legion 16IRX9H

Lenovo Legion 16IRX9H has the very same PCI SSID (17aa:3842) as the
recently added quirk for Lenovo Thinkpad X G2 IAH, but it needs a
different qurik.  Although the quirk for Legion 16IRX9H is present,
it's not applied because the PCI SSID 17aa:3842 matches at first and
the new quirk for Thinkpad X G2 is taken instead.

As a workaround, put the codec SSID matching (17aa:38cd) for Legion
before the conflicting PCI SSID quirk entry.

Fixes: f2293e7b2ddd ("ALSA: hda/realtek: Enable all four speaker amps on Lenovo ThinkBook X G2 IAH")
Cc: <stable@vger.kernel.org>
Reported-by: william <assassinshalo29@gmail.com>
Closes: https://lore.kernel.org/CAFjFWEjt+DPJ_gM1uTBZ_NoV6-3mi57ArjZ_Qdah2DqY-GCD1w@mail.gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/hda/codecs/realtek/alc269.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 2c541c68ff5b..1d609584e778 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -8542,6 +8542,8 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x3827, "Ideapad S740", ALC285_FIXUP_IDEAPAD_S740_COEF),
 	SND_PCI_QUIRK(0x17aa, 0x3834, "Lenovo IdeaPad Slim 9i 14ITL5", ALC287_FIXUP_YOGA7_14ITL_SPEAKERS),
 	SND_PCI_QUIRK(0x17aa, 0x383d, "Legion Y9000X 2019", ALC285_FIXUP_LEGION_Y9000X_SPEAKERS),
+	/* Legion 16IRX9H shares PCI SSID 17aa:3842 with Thinkpad X G2 below */
+	HDA_CODEC_QUIRK(0x17aa, 0x38cd, "Lenovo Legion 16IRX9H", ALC287_FIXUP_TAS2781_I2C),
 	SND_PCI_QUIRK(0x17aa, 0x3842, "ThinkBook X G2 IAH", ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_4_THINKPAD),
 	/* IdeaPad Pro 5 14IAH10 shares PCI SSID 17aa:3843 with Yoga Book 9i;
 	 * use codec SSID to distinguish them
-- 
2.53.0


      parent reply	other threads:[~2026-11-17  9:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  1:24 [REGRESSION] ALSA: hda/realtek: no speaker sound on Lenovo Legion 16IRX9H since f2293e7b2ddd (PCI SSID 17aa:3842 shared with ThinkBook X G2 IAH) william
2026-11-16  8:29 ` Thorsten Leemhuis
2026-11-16 12:34   ` Sasha Levin
2026-11-17  9:10 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v75vzuvb.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=assassinshalo29@gmail.com \
    --cc=evgeny@devduty.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=regressions@lists.linux.dev \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox