From: Takashi Iwai <tiwai@suse.de>
To: Haotian Zhang <vulab@iscas.ac.cn>
Cc: perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: vxpocket: Fix resource leak in vxpocket_probe error path
Date: Mon, 15 Dec 2025 09:20:24 +0100 [thread overview]
Message-ID: <87v7i86trr.wl-tiwai@suse.de> (raw)
In-Reply-To: <20251215042652.695-1-vulab@iscas.ac.cn>
On Mon, 15 Dec 2025 05:26:52 +0100,
Haotian Zhang wrote:
>
> When vxpocket_config() fails, vxpocket_probe() returns the error code
> directly without freeing the sound card resources allocated by
> snd_card_new(), which leads to a memory leak.
>
> Add proper error handling to free the sound card and clear the
> allocation bit when vxpocket_config() fails.
>
> Fixes: 15b99ac17295 ("[PATCH] pcmcia: add return value to _config() functions")
> Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Applied now. Thanks.
I guess a similar bug is present in
sound/pcmcia/pdaudiocf/pdaudiocf.c, too.
Care to fix it as well? ;)
Takashi
prev parent reply other threads:[~2025-12-15 8:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 4:26 [PATCH] ALSA: vxpocket: Fix resource leak in vxpocket_probe error path Haotian Zhang
2025-12-15 8:20 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v7i86trr.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox