Re: [PATCH 0/9] ALSA: seq: Use bus specific probe and remove

[Takashi Iwai <tiwai@suse.de>]

On Tue, 02 Dec 2025 13:35:49 +0100,
Uwe Kleine-König wrote:
> 
> Hello,
> 
> for the quest to drop .probe(), .remove() and .shutdown() from struct
> device_driver, this patch set converts all seq drivers to use bus type
> callbacks.
> 
> The dependencies here are:
>  - patches #2 - #8 depend (only) on patch #1
>  - patch #9 depends on #1 - #8
> but I guess this series will go in in a single go and there is no need
> to coordinate merging.
> 
> This series is compile tested only, as I have no access to seq devices.
> Still I'm reasonably sure that there is no user-visible effect when this
> series is applied. (There is a runtime warning introduced by patch #1
> that goes away with patches #2-#8 again. So future bisections suffer a
> tiny bit.)

It looks OK though a quick glance, but since it's a bit too late for
6.19, I'll postpone this series for 6.20, unless those are urgently
required for any reason.


thanks,

Takashi

> 
> Best regards
> Uwe
> 
> Uwe Kleine-König (9):
>   ALSA: seq: Use bus specific probe and remove
>   ALSA: seq: midi: Convert to snd_seq bus probe mechanism
>   ALSA: seq: ump: Convert to snd_seq bus probe mechanism
>   ALSA: opl3: Convert to snd_seq bus probe mechanism
>   ALSA: opl4: Convert to snd_seq bus probe mechanism
>   ALSA: sb: Convert to snd_seq bus probe mechanism
>   ALSA: emu10k1: Convert to snd_seq bus probe mechanism
>   ALSA: seq: oss: Convert to snd_seq bus probe mechanism
>   ALSA: seq: Refuse to probe seq drivers with non-bus probe or remove
> 
>  include/sound/seq_device.h         |  2 ++
>  sound/core/seq/oss/seq_oss.c       |  4 ++--
>  sound/core/seq/oss/seq_oss_synth.c | 12 ++++--------
>  sound/core/seq/oss/seq_oss_synth.h |  4 ++--
>  sound/core/seq/seq_midi.c          | 15 ++++++---------
>  sound/core/seq/seq_ump_client.c    | 11 ++++-------
>  sound/core/seq_device.c            | 26 +++++++++++++++++++++++++-
>  sound/drivers/opl3/opl3_seq.c      | 13 +++++--------
>  sound/drivers/opl4/opl4_seq.c      | 10 ++++------
>  sound/isa/sb/emu8000_synth.c       | 13 +++++--------
>  sound/pci/emu10k1/emu10k1_synth.c  | 13 +++++--------
>  11 files changed, 64 insertions(+), 59 deletions(-)
> 
> 
> base-commit: 7d0a66e4bb9081d75c82ec4957c50034cb0ea449
> -- 
> 2.47.3
>