Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Vasiliy Kovalev <kovalev@altlinux.org>
Cc: Takashi Iwai <tiwai@suse.de>, Takashi Iwai <tiwai@suse.com>,
	Jaroslav Kysela <perex@perex.cz>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	Nikita Maksimov <nickstogramm@yandex.ru>
Subject: Re: [PATCH] ALSA: hda/via: Apply runtime PM workaround for ASUS X55A
Date: Sun, 18 Oct 2026 11:34:13 +0200	[thread overview]
Message-ID: <87wlrfz71m.wl-tiwai@suse.de> (raw)
In-Reply-To: <ffd3e030-c056-da1e-0549-c41d7681abc2@basealt.ru>

On Sun, 18 Oct 2026 10:50:53 +0200,
Vasiliy Kovalev wrote:
> 
> Hi,
> 
> On 10/18/26 11:33, Takashi Iwai wrote:
> > On Sat, 17 Oct 2026 12:12:57 +0200,
> > Vasiliy Kovalev wrote:
> >> 
> >> ASUS X55A requires the same workaround like other machines with
> >> VT1802, otherwise it loses the codec power on a few nodes and the
> >> sound stays silent.
> >> 
> >> Fixes: a0645daf1610 ("ALSA: HDA: Early Forbid of runtime PM")
> >> Link: https://bugzilla.altlinux.org/45606
> >> Cc: <stable@vger.kernel.org>
> >> Tested-by: Nikita Maksimov <nickstogramm@yandex.ru>
> >> Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org>
> > 
> > The addition of a quirk is OK, but is Fixes tag really pointing to the
> > culprit?  The commit is for forbidding the runtime PM, and I see no
> > clear reason how this commit breaks.
> 
> I followed the precedent of your B23E patch[1], which carried the
> same Fixes tag. If you don't think it applies here, happy to drop
> it - let me know if you'd rather remove it yourself or have me
> send a v2 without it (keeping Cc: stable).
> 
> [1] https://lore.kernel.org/all/20210817052432.14751-1-tiwai@suse.de/

OK, that looks like a failure in the previous commit, then.
I applied to for-next branch now without Fixes tag.


thanks,

Takashi

      reply	other threads:[~2026-10-18  9:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-17 10:12 [PATCH] ALSA: hda/via: Apply runtime PM workaround for ASUS X55A Vasiliy Kovalev
2026-10-18  8:33 ` Takashi Iwai
2026-10-18  8:50   ` Vasiliy Kovalev
2026-10-18  9:34     ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wlrfz71m.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=kovalev@altlinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=nickstogramm@yandex.ru \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox