Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Adam Holliday <dochollidayxx@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Kailang Yang <kailang@realtek.com>,
	Stefan Binding <sbinding@opensource.cirrus.com>,
	Chris Chiu <chris.chiu@canonical.com>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for ASUS ROG Zephyrus Duo GX551QS
Date: Tue, 30 Sep 2025 14:38:23 +0200	[thread overview]
Message-ID: <87wm5gjetc.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250930011507.12037-1-dochollidayxx@gmail.com>

On Tue, 30 Sep 2025 03:15:07 +0200,
Adam Holliday wrote:
> 
> The ASUS ROG Zephyrus Duo 15 SE (GX551QS) with ALC289 codec requires specific
> pin configuration for proper volume control. Without this quirk, volume
> adjustments produce a muffled sound effect as only certain channels attenuate,
> leaving bass frequency at full volume.
> 
> Testing via hdajackretask confirms these pin tweaks fix the issue:
> - Pin 0x17: Internal Speaker (LFE)
> - Pin 0x1e: Internal Speaker
> 
> Signed-off-by: Adam Holliday <dochollidayxx@gmail.com>

The code change looks OK, but the patch couldn't be applied cleanly --
some spaces seem malformed.  Could you resubmit properly?
At best, test to send to yourself and check whether it really works
before the actual submission.


thanks,

Takashi

  reply	other threads:[~2025-09-30 12:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-30  1:15 [PATCH] ALSA: hda/realtek: Add quirk for ASUS ROG Zephyrus Duo GX551QS Adam Holliday
2025-09-30 12:38 ` Takashi Iwai [this message]
2025-09-30 15:09   ` [PATCH] ALSA: hda/realtek: Add quirk for ASUS ROG Zephyrus Duo Adam Holliday
2025-10-04 13:47     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wm5gjetc.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=chris.chiu@canonical.com \
    --cc=dochollidayxx@gmail.com \
    --cc=kailang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sbinding@opensource.cirrus.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox