From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="gfkcn5ml"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="SqePCo65"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="gfkcn5ml"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="SqePCo65" Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5A5AD0 for ; Mon, 11 Dec 2023 23:46:54 -0800 (PST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C0E951FCFE; Tue, 12 Dec 2023 07:46:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702367212; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rnjqNEY6w33ej5HuvEO7MGMi/PMAgiy8NiABUKG3yXU=; b=gfkcn5mlYepsx9pNj6CXCWYyqZMW08Q0eBUxqSrOSb2ZOEzTzJWW+VOfFe9obzl9rPzzOO Fxq/HsKMPVR1RHIRiERGAyoZV0r88CJ5+GVMZ5gls6IzEER2NGsa87wrMytBihvXOatvSI csGOZdB96Bzx8NJNmUW17h84fGZjwqI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702367212; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rnjqNEY6w33ej5HuvEO7MGMi/PMAgiy8NiABUKG3yXU=; b=SqePCo65tnF1CDR432uET9290tZfmAk1i0xxV4O3r2gTy1sv0ehtD/Az4TieC66ugO6Tgd cC9SxNem5eV/Z/BQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702367212; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rnjqNEY6w33ej5HuvEO7MGMi/PMAgiy8NiABUKG3yXU=; b=gfkcn5mlYepsx9pNj6CXCWYyqZMW08Q0eBUxqSrOSb2ZOEzTzJWW+VOfFe9obzl9rPzzOO Fxq/HsKMPVR1RHIRiERGAyoZV0r88CJ5+GVMZ5gls6IzEER2NGsa87wrMytBihvXOatvSI csGOZdB96Bzx8NJNmUW17h84fGZjwqI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702367212; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rnjqNEY6w33ej5HuvEO7MGMi/PMAgiy8NiABUKG3yXU=; b=SqePCo65tnF1CDR432uET9290tZfmAk1i0xxV4O3r2gTy1sv0ehtD/Az4TieC66ugO6Tgd cC9SxNem5eV/Z/BQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 90C4713725; Tue, 12 Dec 2023 07:46:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id hqb3IOwPeGVsZAAAD6G6ig (envelope-from ); Tue, 12 Dec 2023 07:46:52 +0000 Date: Tue, 12 Dec 2023 08:46:52 +0100 Message-ID: <87wmtjhngz.wl-tiwai@suse.de> From: Takashi Iwai To: =?ISO-8859-1?Q?Cl=E9ment?= Villeret Cc: linux-sound@vger.kernel.org, perex@perex.cz, tiwai@suse.com Subject: Re: ALSA: hda/realtek: Add quirk for ASUS ROG GV302XA In-Reply-To: <3cad5ffd-22dd-4bd5-8c08-1a5530489923@gmail.com> References: <3cad5ffd-22dd-4bd5-8c08-1a5530489923@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Level: ************ X-Spam-Score: 12.59 X-Spam-Level: Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gfkcn5ml; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=SqePCo65; dmarc=pass (policy=none) header.from=suse.de; spf=softfail (smtp-out2.suse.de: 2a07:de40:b281:104:10:150:64:97 is neither permitted nor denied by domain of tiwai@suse.de) smtp.mailfrom=tiwai@suse.de X-Rspamd-Server: rspamd2 X-Spamd-Result: default: False [-6.52 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all:c]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.de:+]; DMARC_POLICY_ALLOW(0.00)[suse.de,none]; MX_GOOD(-0.01)[]; DMARC_POLICY_ALLOW_WITH_FAILURES(-0.50)[]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; NEURAL_HAM_SHORT(-0.20)[-1.000]; BAYES_HAM(-0.01)[49.24%]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; WHITELIST_DMARC(-7.00)[suse.de:D:+]; MID_CONTAINS_FROM(1.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; SUSPICIOUS_RECIPS(1.50)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from] X-Spam-Score: -6.52 X-Rspamd-Queue-Id: C0E951FCFE X-Spam-Flag: NO On Tue, 12 Dec 2023 08:43:36 +0100, Clément Villeret wrote: > > Commit message : Please drop a superfluous tag. > Asus ROG Flowx13 (GV302XA) seems require same patch as others asus product (UM3402YAR, UM3406HA...). This permit to load the correct firmware and don't loose audio after waking up from sleep or hibernate. Your Signed-off-by tag is mandatory for the patch to be merged to the upstream. Please take a look at Documentation/process/submitting-patches.rst for details. About the code change: > @@ -9954,6 +9954,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), > SND_PCI_QUIRK(0x1043, 0x1573, "ASUS GZ301V", ALC285_FIXUP_ASUS_HEADSET_MIC), > SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", ALC294_FIXUP_ASUS_DUAL_SPK), > + SND_PCI_QUIRK(0x1043, 0x1533, "ASUS GV302XA", ALC287_FIXUP_CS35L41_I2C_2), > SND_PCI_QUIRK(0x1043, 0x1663, "ASUS GU603ZV", ALC285_FIXUP_ASUS_HEADSET_MIC), > SND_PCI_QUIRK(0x1043, 0x1683, "ASUS UM3402YAR", ALC287_FIXUP_CS35L41_I2C_2), > SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401), The table is sorted in PCI SSID order. Please put at the right position. Could you resubmit the patch with the corrections above? thanks, Takashi