From: Takashi Iwai <tiwai@suse.de>
To: Evgenii Burenchev <evg28bur@yandex.ru>
Cc: stable@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
perex@perex.cz, tiwai@suse.com, u.kleine-koenig@baylibre.com,
kees@kernel.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH] ALSA: via82xx: Remove unreachable branch in snd_via686_pcm_pointer()
Date: Tue, 07 Jul 2026 16:35:00 +0200 [thread overview]
Message-ID: <87y0fm6f6z.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260706131638.15311-1-evg28bur@yandex.ru>
On Mon, 06 Jul 2026 15:16:34 +0200,
Evgenii Burenchev wrote:
>
> The condition
>
> if (count && size < count)
>
> can never evaluate to true.
>
> The VIA DMA count register is masked with 0x00ffffff before use, while
> the DMA buffer size is limited to 0x00fffffe bytes. As a result, 'count'
> can never exceed 'size', making the condition permanently false.
>
> This branch has therefore been unreachable since the driver was
> introduced. Remove the unreachable branch without changing runtime
> behavior.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Evgenii Burenchev <evg28bur@yandex.ru>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2026-07-07 14:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 13:16 [PATCH] ALSA: via82xx: Remove unreachable branch in snd_via686_pcm_pointer() Evgenii Burenchev
2026-07-07 14:35 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y0fm6f6z.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=evg28bur@yandex.ru \
--cc=gregkh@linuxfoundation.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox