Re: [PATCH] ALSA: scarlett2: Add Vocaster speaker/headphone mute controls

[Takashi Iwai <tiwai@suse.de>]

On Thu, 04 Sep 2025 17:53:51 +0200,
Geoffrey D. Bennett wrote:
> 
> Add support for the speaker and headphone mute controls on Focusrite
> Vocaster interfaces. Unlike other Focusrite interfaces, these mute
> controls are per-output, not per-channel.
> 
> Signed-off-by: Geoffrey D. Bennett <g@b4.vu>
> ---
>  sound/usb/mixer_scarlett2.c | 97 ++++++++++++++++++++++++++++++++++++-
>  1 file changed, 96 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/usb/mixer_scarlett2.c b/sound/usb/mixer_scarlett2.c
> index e762d6110b1a..f2446bf3982c 100644
> --- a/sound/usb/mixer_scarlett2.c
> +++ b/sound/usb/mixer_scarlett2.c
> @@ -10,8 +10,9 @@
>   *   - Solo/2i2/4i4 Gen 4
>   *   - Clarett 2Pre/4Pre/8Pre USB
>   *   - Clarett+ 2Pre/4Pre/8Pre
> + *   - Vocaster One/Two
>   *
> - *   Copyright (c) 2018-2024 by Geoffrey D. Bennett <g at b4.vu>
> + *   Copyright (c) 2018-2025 by Geoffrey D. Bennett <g at b4.vu>
>   *   Copyright (c) 2020-2021 by Vladimir Sadovnikov <sadko4u@gmail.com>
>   *   Copyright (c) 2022 by Christian Colglazier <christian@cacolglazier.com>
>   *
> @@ -75,6 +76,9 @@
>   * to many LinuxMusicians people and to Focusrite for hardware
>   * donations).
>   *
> + * Support for Vocaster One and Two added in Mar 2024 (thanks to many
> + * LinuxMusicians people and to Focusrite for hardware donations).
> + *
>   * This ALSA mixer gives access to (model-dependent):
>   *  - input, output, mixer-matrix muxes
>   *  - mixer-matrix gain stages
> @@ -364,6 +368,21 @@ static const char *const scarlett2_dim_mute_names[SCARLETT2_DIM_MUTE_COUNT] = {
>  	"Mute Playback Switch", "Dim Playback Switch"
>  };
>  
> +/* Vocaster One speaker/headphone mute names */
> +static const char *const vocaster_one_sp_hp_mute_names[] = {
> +	"Speaker Mute Playback Switch",
> +	"Headphones Mute Playback Switch",

Usually "XXX Playback Switch" indicates that it's a switch for
mute/unmute, hence we don't put "Mute" here.

Actually, having a "mute" switch makes difficult to judge how it
behaves: when the mixer switch is "on", is it muted, i.e. the sound
goes off?  It's a contradiction to other mixer controls.


thanks,

Takashi