From: Takashi Iwai <tiwai@suse.de>
To: Guangshuo Li <liguangshuo@mail.sdu.edu.cn>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: pcm: Fix potential device leak on partial registration failure
Date: Wed, 18 Nov 2026 13:52:27 +0100 [thread overview]
Message-ID: <87zev6wbck.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261117-571e631490-alsa-pcm-0@mail.sdu.edu.cn>
On Tue, 17 Nov 2026 15:47:05 +0100,
Guangshuo Li wrote:
>
> If capture registration fails after playback was registered, the PCM
> remains in the BUILD state. Card teardown therefore skips its disconnect
> callback, leaving the playback device registered and holding its parent
> card reference.
>
> Unregister previously registered streams and release their timers before
> returning the registration error.
>
> This issue was found by our static analysis tool under development.
>
> Fixes: ef46c7af93f9 ("ALSA: pcm: Embed struct device")
> Signed-off-by: Guangshuo Li <liguangshuo@mail.sdu.edu.cn>
Applied to for-next branch. Thanks.
Takashi
prev parent reply other threads:[~2026-11-18 12:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 14:47 [PATCH] ALSA: pcm: Fix potential device leak on partial registration failure Guangshuo Li
2026-11-18 12:52 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zev6wbck.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=liguangshuo@mail.sdu.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox