From: Takashi Iwai <tiwai@suse.de>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: tiwai@suse.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH] ALSA: hda/cirrus_scodec_test: Fix incorrect setup of gpiochip
Date: Tue, 13 Jan 2026 14:14:39 +0100 [thread overview]
Message-ID: <87zf6hpscg.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260113130954.574670-1-rf@opensource.cirrus.com>
On Tue, 13 Jan 2026 14:09:54 +0100,
Richard Fitzgerald wrote:
>
> Set gpiochip parent to the struct device of the dummy GPIO driver
> so that the software node will be associated with the GPIO chip.
>
> The recent commit e5d527be7e698 ("gpio: swnode: don't use the
> swnode's name as the key for GPIO lookup") broke cirrus_scodec_test,
> because the software node no longer gets associated with the GPIO
> driver by name.
>
> Instead, setting struct gpio_chip.parent to the owning struct device
> will find the node using a normal fwnode lookup.
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
> Fixes: 2144833e7b414 ("ALSA: hda: cirrus_scodec: Add KUnit test")
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2026-01-13 13:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 13:09 [PATCH] ALSA: hda/cirrus_scodec_test: Fix incorrect setup of gpiochip Richard Fitzgerald
2026-01-13 13:14 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zf6hpscg.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox