Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Alexey Klimov <alexey.klimov@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	Srinivas Kandagatla <srini@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Patrick Lai <plai@qti.qualcomm.com>,
	Annemarie Porter <annemari@quicinc.com>,
	srinivas.kandagatla@oss.qualcomm.com,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	kernel@oss.qualcomm.com,
	Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
Subject: Re: [PATCH v2 1/2] ALSA: compress: add raw opus codec define and opus decoder structs
Date: Wed, 10 Sep 2025 11:17:29 +0200	[thread overview]
Message-ID: <87zfb2vf86.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250910-opus_codec_rfc_v1-v2-1-35fb6536df6b@linaro.org>

On Wed, 10 Sep 2025 10:11:41 +0200,
Alexey Klimov wrote:
> +struct snd_dec_opus {
> +	union {
> +		struct {
> +			__u8 minor:4;
> +			__u8 major:4;
> +		} __attribute__((packed)) fields;

Bit fields aren't really good for ABI definition, as it's not well
defined.  I'd rather leave it as a u8.  If any, you can provide a
bitmask definition or a macro to retrieve the version numbers.

Also, don't forget to bump the API protocol number.
It's been already increased to 0.4.0 for 64bit tstamp support, and
yours need to increase one more.

(That is, please make sure to create patches based on linux-next, or
 for-next branch of sound git tree.)


thanks,

Takashi

  reply	other threads:[~2025-09-10  9:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-10  8:11 [PATCH v2 0/2] Add raw OPUS codec support for compress offload Alexey Klimov
2025-09-10  8:11 ` [PATCH v2 1/2] ALSA: compress: add raw opus codec define and opus decoder structs Alexey Klimov
2025-09-10  9:17   ` Takashi Iwai [this message]
2025-09-16  4:20     ` Alexey Klimov
2025-09-16  6:15       ` Takashi Iwai
2025-09-10  8:11 ` [PATCH v2 2/2] ASoC: qcom: qdsp6/audioreach: add support for offloading raw opus playback Alexey Klimov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfb2vf86.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alexey.klimov@linaro.org \
    --cc=annemari@quicinc.com \
    --cc=broonie@kernel.org \
    --cc=ekansh.gupta@oss.qualcomm.com \
    --cc=kernel@oss.qualcomm.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=plai@qti.qualcomm.com \
    --cc=srini@kernel.org \
    --cc=srinivas.kandagatla@oss.qualcomm.com \
    --cc=tiwai@suse.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox