From: Takashi Iwai <tiwai@suse.de>
To: Karol Kosik <k.kosik@outlook.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
Johan Carlsson <johan.carlsson@teenage.engineering>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Fix NULL pointer deref in snd_usb_power_domain_set()
Date: Thu, 10 Oct 2024 14:02:37 +0200 [thread overview]
Message-ID: <87zfnc17z6.wl-tiwai@suse.de> (raw)
In-Reply-To: <AS8P190MB1285B563C6B5394DB274813FEC782@AS8P190MB1285.EURP190.PROD.OUTLOOK.COM>
On Thu, 10 Oct 2024 08:59:10 +0200,
Karol Kosik wrote:
>
> Commit adding support for multiple control interfaces expanded struct
> snd_usb_power_domain with pointer to control interface for proper control
> message routing but missed one initialization point of this structure,
> which has left new field with NULL value.
>
> Standard mandates that each device has at least one control interface and
> code responsible for power domain does not check for NULL values when
> querying for control interface. This caused some USB devices to crash
> the kernel.
>
> Fixes: 6aa8700150f7 ("ALSA: usb-audio: Support multiple control interfaces")
>
> Signed-off-by: Karol Kosik <k.kosik@outlook.com>
It seems that tabs got broken by your mailer, so I applied manually
now. Please fix your mailer setup at the next time you submit.
thanks,
Takashi
prev parent reply other threads:[~2024-10-10 12:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 6:59 [PATCH] ALSA: usb-audio: Fix NULL pointer deref in snd_usb_power_domain_set() Karol Kosik
2024-10-10 12:02 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfnc17z6.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=johan.carlsson@teenage.engineering \
--cc=k.kosik@outlook.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox