From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: John Meyer <jmeyer@fdma.com>, linux-sound@vger.kernel.org
Cc: yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.dev,
kai.vehmanen@linux.intel.com, ranjani.sridharan@linux.intel.com,
peter.ujfalusi@linux.intel.com
Subject: Re: [PATCH 2/2] ASoC: intel: ptl: Add machine driver entry for Dell XPS 14 DA14260
Date: Thu, 2 Apr 2026 10:12:48 +0100 [thread overview]
Message-ID: <881307ea-0caa-4fbe-86f6-bcd6bc40b737@opensource.cirrus.com> (raw)
In-Reply-To: <20260402001236.17086-2-jmeyer@fdma.com>
On 02/04/2026 1:12 am, John Meyer wrote:
> The Dell XPS 14 DA14260 (Panther Lake) uses the following SoundWire
> audio topology:
>
> Link 0: CS42L45 (mfr 0x01FA, part 0x4245) -- SDCA headset codec
> ADR 0x00003001FA424501
> Endpoints: UAJ (jack playback), SmartMic (DMIC), UAJ (jack
> capture)
>
> Link 2: Two CS35L57 speaker amps (mfr 0x01FA, part 0x3557)
> ADR 0x00023201FA355701 (left/AMP1)
> ADR 0x00023301FA355701 (AMP2)
>
> Link 3: Two CS35L57 speaker amps
> ADR 0x00033001FA355701 (right/AMP3)
> ADR 0x00033101FA355701 (AMP4)
>
> ADR values were obtained from the platform ACPI DSDT.
>
> Add the necessary ADR device arrays, endpoint descriptors, link array,
> and machine table entry. The CS42L45 uses three non-aggregated
> endpoints (jack playback/capture and DMIC) matching the SDCA functions
> advertised by the hardware. The four CS35L57 amps use the existing
> aggregated speaker endpoint descriptors (spk_l, spk_2, spk_r, spk_3).
>
> The topology file name follows the established PTL naming convention.
> Note: a PTL-specific topology file does not yet exist; users can
> symlink sof-lnl-cs42l43-l0-cs35l56-l23.tplg as a workaround until
> a dedicated PTL topology is submitted to linux-firmware.
>
No. This is completely the wrong thing to do, and isn't even
necessary because these parts are already supported and working.
PTL doesn't need match entries or hardcoded tplgs.
You seem to be sending random patches that
(a) are not necessary, (b) are wrong, (c) will break things
> Note: a PTL-specific topology file does not yet exist; users can
The PTL tplgs do exist. These are SDCA parts that use the function
topologies.
next prev parent reply other threads:[~2026-04-02 9:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 0:12 [PATCH 1/2] ASoC: sdw_utils: Add CS42L45 and CS35L57 codec table entries John Meyer
2026-04-02 0:12 ` [PATCH 2/2] ASoC: intel: ptl: Add machine driver entry for Dell XPS 14 DA14260 John Meyer
2026-04-02 9:12 ` Richard Fitzgerald [this message]
2026-04-02 9:18 ` [PATCH 1/2] ASoC: sdw_utils: Add CS42L45 and CS35L57 codec table entries Richard Fitzgerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=881307ea-0caa-4fbe-86f6-bcd6bc40b737@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=jmeyer@fdma.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=linux-sound@vger.kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=ranjani.sridharan@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox