From: "Arnd Bergmann" <arnd@arndb.de>
To: "Binbin Zhou" <zhoubinbin@loongson.cn>,
"Arnd Bergmann" <arnd@kernel.org>
Cc: "Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Tang Bin" <tangbin@cmss.chinamobile.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
"Binbin Zhou" <zhoubb.aaron@gmail.com>
Subject: Re: [PATCH] ASoC: loongson: make loongson-i2s.o a separate module
Date: Wed, 16 Oct 2024 07:02:36 +0000 [thread overview]
Message-ID: <887501dc-6bcc-4f98-b472-af609c4c370b@app.fastmail.com> (raw)
In-Reply-To: <52c7e318.434f.192941d2bee.Coremail.zhoubinbin@loongson.cn>
On Wed, Oct 16, 2024, at 06:56, 周彬彬 wrote:
>> -----Original Messages-----
>> From: "Arnd Bergmann" <arnd@kernel.org>
>> Send time:Tuesday, 10/15/2024 23:09:54
>> To: "Liam Girdwood" <lgirdwood@gmail.com>, "Mark Brown" <broonie@kernel.org>, "Jaroslav Kysela" <perex@perex.cz>, "Takashi Iwai" <tiwai@suse.com>, "Binbin Zhou" <zhoubinbin@loongson.cn>
>> Cc: "Arnd Bergmann" <arnd@arndb.de>, tangbin <tangbin@cmss.chinamobile.com>, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
>> Subject: [PATCH] ASoC: loongson: make loongson-i2s.o a separate module
>>
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> An object file should not be linked into multiple modules and/or
>> vmlinux:
>>
>> scripts/Makefile.build:221: /home/arnd/arm-soc/sound/soc/loongson/Makefile: loongson_i2s.o is added to multiple modules: snd-soc-loongson-i2s-pci snd-soc-loongson-i2s-plat
>
> I would like to ask for some advice.
> I didn't notice this warning before when I submitted the patch, is
> there some specific compilation option that needs to be turned on?
I think this is one of the warnings that are currently
only enabled when building with "make W=1". I have this enabled
by default as I hope to make it a default warning soon.
In general, I would recommend to build new driver code with W=1
before submitting.
Arnd
next prev parent reply other threads:[~2024-10-16 7:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 15:09 [PATCH] ASoC: loongson: make loongson-i2s.o a separate module Arnd Bergmann
2024-10-16 6:56 ` 周彬彬
2024-10-16 7:02 ` Arnd Bergmann [this message]
2024-10-16 8:02 ` Binbin Zhou
2024-10-18 17:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=887501dc-6bcc-4f98-b472-af609c4c370b@app.fastmail.com \
--to=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tangbin@cmss.chinamobile.com \
--cc=tiwai@suse.com \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox