Re: [PATCH] ASoC: wm8998: Add Kconfig prompt

[Richard Fitzgerald <rf@opensource.cirrus.com>]

On 21/4/25 15:15, Charles Keepax wrote:
> On Fri, Apr 18, 2025 at 10:22:04PM +0200, André Apitzsch via B4 Relay wrote:
>> From: André Apitzsch <git@apitzsch.eu>
>>
>> Add tristate prompt to allow codec selection.
>>
>> Signed-off-by: André Apitzsch <git@apitzsch.eu>
>> ---
> 
> Generally its good to say why one wants to make the symbol
> selectable, usually its to use it with simple card, although at
> least historically I think simple card struggled to handle the
> required set_sysclk calls for these codecs.
> 
> But I have no objection to this being exported:
> 
> Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> 
> Thanks,
> Charles

Yeah, I just checked simple-card and friends and I see no evidence that
it has a way to make the necessary calls to enable the clocks and PLL
on the WM8998.

Of course, the intended machine driver might not be simple/audio-graph
so that might not be a problem. Though a more specific machine driver
could simply select the codec driver it uses.

This is why it helps to say why you need this change.