linux-sound.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alexey Klimov <alexey.klimov@linaro.org>
Cc: Srinivas Kandagatla <srini@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Stephen Boyd <sboyd@kernel.org>, Lee Jones <lee@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Subject: Re: [PATCH 1/3] dt-bindings: sound: add bindings for pm4125 audio codec
Date: Wed, 2 Jul 2025 08:22:26 +0200	[thread overview]
Message-ID: <8d869d3b-c815-49fb-a367-c404bfb55d98@kernel.org> (raw)
In-Reply-To: <DB13YER95DCW.1IBRJ65LED5GX@linaro.org>

On 02/07/2025 01:30, Alexey Klimov wrote:
>>>>> +  It has RX and TX Soundwire slave devices. This bindings is for the
>>>>> +  slave devices.
>>>>
>>>> Last sentence is redundant and makes no sense. Codec has only slave
>>>> devices, so how this can be anything else than for slave devices?
>>>
>>> This came from other similar files that describe bindings for child codec nodes
>>> of soundwire nodes. For example from qcom,wcd937x-sdw.yaml.
>>> Should this be rephrased to "This bindings is for the soundwire slave devices." ?
>>
>> You just pasted the same, so I don't get how you want to rephrase into
>> the same sentence.
> 
> Not really.
> Original sentence: "This bindings is for the slave devices."
> Sentence from my email: "This bindings is for the soundwire slave devices."
> 
> The difference is 1 word.
> If it doesn't work, then maybe any suggestions?
> 
> Maybe "This bindings is for audio codec node that must be a child node of the
> associated soundwire master node."?
No, drop, it's not the pattern in the bindings. We don't explain that
I2C device should be in I2C bus, because that's obvious. Saying this is
a Soundwire device should be enough.

Best regards,
Krzysztof

  reply	other threads:[~2025-07-02  6:22 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-25 23:50 [PATCH 0/3] Add PM4125 audio codec driver Alexey Klimov
2025-06-25 23:50 ` [PATCH 1/3] dt-bindings: sound: add bindings for pm4125 audio codec Alexey Klimov
2025-06-26  1:30   ` Rob Herring (Arm)
2025-06-26 11:08     ` Alexey Klimov
2025-06-26  6:13   ` Krzysztof Kozlowski
2025-06-28 16:41     ` Alexey Klimov
2025-06-29 14:59       ` Dmitry Baryshkov
2025-06-30  8:21       ` Krzysztof Kozlowski
2025-07-01 23:30         ` Alexey Klimov
2025-07-02  6:22           ` Krzysztof Kozlowski [this message]
2025-06-25 23:50 ` [PATCH 2/3] dt-bindings: mfd: qcom,spmi-pmic: add " Alexey Klimov
2025-06-26  8:48   ` Krzysztof Kozlowski
2025-06-28 16:42     ` Alexey Klimov
2025-06-29 15:00       ` Dmitry Baryshkov
2025-06-30  8:18       ` Krzysztof Kozlowski
2025-06-25 23:50 ` [PATCH 3/3] ASoC: codecs: add new pm4125 audio codec driver Alexey Klimov
2025-06-26  6:19   ` Krzysztof Kozlowski
2025-07-10 15:37     ` Alexey Klimov
2025-06-26 11:56   ` Mark Brown
2025-07-01 19:35     ` Alexey Klimov
2025-07-01 21:04       ` Mark Brown
2025-07-10 14:45         ` Alexey Klimov
2025-06-28 20:24   ` Srinivas Kandagatla
2025-07-02  1:43     ` Alexey Klimov
2025-07-03 12:50       ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d869d3b-c815-49fb-a367-c404bfb55d98@kernel.org \
    --to=krzk@kernel.org \
    --cc=alexey.klimov@linaro.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=srini@kernel.org \
    --cc=srinivas.kandagatla@oss.qualcomm.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).