From: "Sheetal ." <sheetal@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: broonie@kernel.org, linux-sound@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
jonathanh@nvidia.com, mkumard@nvidia.com, spujar@nvidia.com
Subject: Re: [PATCH V2] ASoC: tegra: Add interconnect support
Date: Tue, 11 Feb 2025 11:20:57 +0530 [thread overview]
Message-ID: <8ed14c8f-fb38-4f50-9319-f6d4e660fae9@nvidia.com> (raw)
In-Reply-To: <ftyikuzu7avxlbyfruubjg5zucbstq5psilehpoahvdhpuqlr6@pcubq7dsm6fw>
On 05-02-2025 19:45, Thierry Reding wrote:
> On Mon, Feb 03, 2025 at 10:53:04AM +0000, Sheetal . wrote:
>> From: Sheetal <sheetal@nvidia.com>
>>
>> Add interconnect framework support to set required audio bandwidth
>> based on PCM device usage. The maximum bandwidth is determined by
>> the number of APE PCM devices and maximum audio format supported.
>>
>> If interconnect property is not defined or INTERCONNECT config
>> is not enabled then the audio usecase will still function.
>>
>> Validate bandwidth updates by reading the interconnect summary sysfs
>> node during PCM device open and close operations.
>>
>> Signed-off-by: Sheetal <sheetal@nvidia.com>
>>
>> ---
>> v2: Fix pcm_id parameter uninitialized warning.
>> ---
>> sound/soc/tegra/Makefile | 2 +-
>> sound/soc/tegra/tegra210_admaif.c | 24 +++++-
>> sound/soc/tegra/tegra210_admaif.h | 9 +-
>> sound/soc/tegra/tegra_isomgr_bw.c | 132 ++++++++++++++++++++++++++++++
>> sound/soc/tegra/tegra_isomgr_bw.h | 31 +++++++
>> 5 files changed, 192 insertions(+), 6 deletions(-)
>> create mode 100644 sound/soc/tegra/tegra_isomgr_bw.c
>> create mode 100644 sound/soc/tegra/tegra_isomgr_bw.h
>>
>> diff --git a/sound/soc/tegra/Makefile b/sound/soc/tegra/Makefile
>> index cea4b0d54378..defea7f53f11 100644
>> --- a/sound/soc/tegra/Makefile
>> +++ b/sound/soc/tegra/Makefile
>> @@ -13,7 +13,7 @@ snd-soc-tegra210-dmic-y := tegra210_dmic.o
>> snd-soc-tegra210-i2s-y := tegra210_i2s.o
>> snd-soc-tegra186-asrc-y := tegra186_asrc.o
>> snd-soc-tegra186-dspk-y := tegra186_dspk.o
>> -snd-soc-tegra210-admaif-y := tegra210_admaif.o
>> +snd-soc-tegra210-admaif-y := tegra210_admaif.o tegra_isomgr_bw.o
> I don't understand why this had to be tacked on like this? Why do we
> need exported symbols for something that looks otherwise very specific
> to ADMAIF? Will this ever be used outside of the ADMAIF driver? If not
> this should just be moved into tegra210_admaif.c and then there's no
> need for the EXPORT_SYMBOL() either.
Thanks for pointing, will send a separate patch to fix this.
>
> Thierry
prev parent reply other threads:[~2025-02-11 5:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 10:53 [PATCH V2] ASoC: tegra: Add interconnect support Sheetal .
2025-02-05 12:44 ` Mark Brown
2025-02-05 14:15 ` Thierry Reding
2025-02-11 5:50 ` Sheetal . [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ed14c8f-fb38-4f50-9319-f6d4e660fae9@nvidia.com \
--to=sheetal@nvidia.com \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox