Re: [PATCH 1/2] ALSA: hda/hdmi: Add helper function to check if a device is HDMI codec

Takashi Iwai
2023-11-28T10:02:37Z

On Tue, 28 Nov 2023 10:53:56 +0100,
Péter Ujfalusi wrote:
>
>
>
> On 28/11/2023 11:39, Takashi Iwai wrote:
> > Hm... I still find it's a bad move to use an exported symbol from
> > another codec driver.
>
> The other option is to check for 0x4 (or address 2), but I'm not sure if
> this is Intel only or universally true for HDMI codecs.
>
> > And, I wonder what if you have a system that has only one HDMI codec
> > without analog one? Would it still work with your change?
>
> Yes, it works with only HDMI codec (for example on SoundWire laptops) or
> with UP2 board which only have HDMI audio support by default.

Interesting. With your patch 2, hdac_hda_hdmi_codec is without the
DAPM definitions, and even if that's the only one that is registered,
it will still work? So it means that it works without DAPM
definitions at all?

Takashi