Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mohammad Rafi Shaik <quic_mohs@quicinc.com>,
	srinivas.kandagatla@linaro.org, bgoswami@quicinc.com,
	broonie@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	andersson@kernel.org, konrad.dybcio@linaro.org,
	lgirdwood@gmail.com, tiwai@suse.com, quic_rohkumar@quicinc.com,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v1 1/2] ASoC: dt-bindings: qcom,qcm6490: Add qcm6490 snd qcs6490 sound card
Date: Wed, 27 Mar 2024 19:37:53 +0100	[thread overview]
Message-ID: <917e99f1-3b4c-4f4d-b264-cb9b764a9222@kernel.org> (raw)
In-Reply-To: <20240327113228.1706975-2-quic_mohs@quicinc.com>

On 27/03/2024 12:32, Mohammad Rafi Shaik wrote:
> Document bindings for the Qualcomm qcm6490 and qcs6490 SoC sound card.
> The bindings are the same as for other newer Qualcomm ADSP sound cards,
> thus keep them in existing qcom,sm8250.yaml file, even though Linux driver
> is separate.
> 
> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
> ---

Patch is trivial, yet people make whitespace mistakes also in trivial
stuff. Therefore please be sure the patch is being tested by CC-ing
appropriate mailing lists.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline), work on fork of kernel
(don't, instead use mainline) or you ignore some maintainers (really
don't). Just use b4 and everything should be fine, although remember
about `b4 prep --auto-to-cc` if you added new patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling.

Please kindly resend and include all necessary To/Cc entries.

Best regards,
Krzysztof


  parent reply	other threads:[~2024-03-27 18:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27 11:32 [PATCH v1 0/2] ASoC: qcom: add support for qcm6490 machine Mohammad Rafi Shaik
2024-03-27 11:32 ` [PATCH v1 1/2] ASoC: dt-bindings: qcom,qcm6490: Add qcm6490 snd qcs6490 sound card Mohammad Rafi Shaik
2024-03-27 12:16   ` Krzysztof Kozlowski
2024-03-27 18:37   ` Krzysztof Kozlowski [this message]
2024-03-27 11:32 ` [PATCH v1 2/2] ASoC: qcom: qcm6490: Add machine driver for qcm6490 Mohammad Rafi Shaik
2024-03-27 12:22   ` Krzysztof Kozlowski
2024-03-27 13:09   ` Dmitry Baryshkov
     [not found]     ` <92b449da-1569-40f9-d8c9-48949c986853@quicinc.com>
2024-03-29 15:58       ` Krzysztof Kozlowski
2024-03-29 18:39       ` Dmitry Baryshkov
2024-04-02  9:20         ` Mohammad Rafi Shaik
2024-04-23 13:05           ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=917e99f1-3b4c-4f4d-b264-cb9b764a9222@kernel.org \
    --to=krzk@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=andersson@kernel.org \
    --cc=bgoswami@quicinc.com \
    --cc=broonie@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=quic_mohs@quicinc.com \
    --cc=quic_rohkumar@quicinc.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox