From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAC5A1494C2 for ; Tue, 25 Jun 2024 09:23:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719307390; cv=none; b=JYfrEhEGulCn0yXU1m4tdbRhgF/IbSVX/IRPwcDibSoWqfAs9pB3XNoMhcXMJ7g9r/h+PjZC2Ot2EPjrJWtuPRraF4ViyZ/X9kW6B9xCofcjXfNFEq3kC3DrGAG2B5JVJ05GUGE7m7S5m3YrLoCH4x7Vp16hkd9ToboAYeqb6qk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719307390; c=relaxed/simple; bh=8SACIkCe/rEQcO2uzmtJLJ1fzayy+8J8k4KMfAwiNO0=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=u1OnzWtuE8Hp0bBBSQzTL30vTcCK/5FaleDqOSVTTv6Vec4zKBS+FTMpxKTOYzO0G6QSqTDtOp0V84VtJiYxJ7Mn0fltNR1Pvcl/OQDRsapmGnQVPq15J6JlCbUs37N0BTkkSXEw9nF8Tbt5cf7jWSgJ+3Akn1xsSySOA9VI7A0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=LDnc7mAO; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="LDnc7mAO" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-52cdbc20faeso4096499e87.1 for ; Tue, 25 Jun 2024 02:23:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1719307385; x=1719912185; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=LlRhdkp6kAFepHjID66aLvJv1DZVnaI5n6pLIDvUVYM=; b=LDnc7mAOVIQyQw9YX0yh10j84cYwv+flect6lYWP9eaDqBApGiMZpKOanwg6r+IoRB NLiJ4vMxUIcXon/uwT6m6NelzHct10gJa8hmWyM6Z9a/RAGvHe/uRfPwQw4+XsmyBe5T KywcylE0go9nqjbopOv0qscZ9I3HAtqLIL0/4Sb+mvxxlhk6KkAO6oh8Zxik258u2Syk T2qtsP4+xpPk4yWc+CwP8ySivyBBw44BIlQLaXJ2BiFxjBo/vm/fleedrZAAPzUbKpUs ZvDCfj9xn2CkBaq7M4vLio//ZtlQwEDnTM/bG98Kglv/wTXWJt2Q31ej+AXUu8Pq01y9 XGIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719307385; x=1719912185; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LlRhdkp6kAFepHjID66aLvJv1DZVnaI5n6pLIDvUVYM=; b=hZlJLA1L1RI/jCfX5JgQcvqmFFFBiaAg3CafN+wzjSxONLRi5fP/dstbXa8Y4lYFoV hvCy5XtfcKf11ydidwjDfDZXNEG/pYTNjLEw0AL0ObqVJp8uw562pKbYWHADhGqRrXJx VVTxqxEszskdFKG0iolqvdseBoJdm9QivLl04oiDq1ibfobBnRMQxeyw/5BDy1th5uiq Bmag3c+Z3FIjO3DcyELmpvWPXr3Ks41lir8LSdizEbTsy+v6mPBV2hueeGxNprhLooUD r217SHf6AvO3AXt4TCTc9nbeDXSrAyAREIHHIyp3V+WbLrB9+6U9TWqZ9OWWnBnhB2cj z8mQ== X-Gm-Message-State: AOJu0YzLxEbLe/mU9ivjz25fyGru/pgGZOh+Ldnj40w8oyeAt0amIqJW H0a9/5XkjOR/+Va1E1P8Zx+tbVxho9nxqfqYseIr/YPZqx8ukSm0JDnjUHtl+qA= X-Google-Smtp-Source: AGHT+IETSGc5PC+/KSXGB7oMPpuYoRZNE+bp/p6Mqr9WgOryoy8prGpDjhg+IZxxEgRRH3Pn20MxJA== X-Received: by 2002:a05:6512:3e24:b0:52c:dff5:8087 with SMTP id 2adb3069b0e04-52ce185f998mr5011614e87.51.1719307384919; Tue, 25 Jun 2024 02:23:04 -0700 (PDT) Received: from [192.168.1.172] ([93.5.22.158]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-366f624cdacsm4476317f8f.70.2024.06.25.02.23.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jun 2024 02:23:04 -0700 (PDT) Message-ID: <95bab90f-b196-4e79-bb88-7fd534cca721@baylibre.com> Date: Tue, 25 Jun 2024 11:23:02 +0200 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Alexandre Mergnat Subject: Re: [PATCH v6 03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC To: Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Lee Jones , Flora Fu , Jaroslav Kysela , Takashi Iwai , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Catalin Marinas , Will Deacon , Rob Herring , Krzysztof Kozlowski Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org References: <20240226-audio-i350-v6-0-f754ec1a7634@baylibre.com> <20240226-audio-i350-v6-3-f754ec1a7634@baylibre.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21/06/2024 17:00, Krzysztof Kozlowski wrote: > On 19/06/2024 16:46, Alexandre Mergnat wrote: >> Add the audio codec sub-device. This sub-device is used to set the >> optional voltage values according to the hardware. >> The properties are: >> - Setup of microphone bias voltage. >> - Setup of the speaker pin pull-down. >> >> Also, add the audio power supply property which is dedicated for >> the audio codec sub-device. >> >> Signed-off-by: Alexandre Mergnat >> --- >> .../devicetree/bindings/mfd/mediatek,mt6357.yaml | 33 ++++++++++++++++++++++ >> 1 file changed, 33 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml >> index 37423c2e0fdf..d95307393e75 100644 >> --- a/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml >> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml >> @@ -37,6 +37,32 @@ properties: >> "#interrupt-cells": >> const: 2 >> >> + vaud28-supply: >> + description: 2.8 volt supply phandle for the audio codec >> + >> + audio-codec: >> + type: object > Still not much improved. You do not have any resources there, so these > should go to the parent node. Hi Krzysztof, vaud28-supply seems to be a mistake that I forward port. In the V4, AFAII, your feedback [1] suggested me to move the vaud28-supply from the "audio-codec" sub-node to the parent node, which for me is the "pmic" (mfd), because the property is considered as power-supply. pwrap { pmic { ... audio-codec { ... Hardware side, vaud28-supply is the output of PMIC-regulator subsystem, and AVDD28 is the input of PMIC-audio-codec subsystem. Then: - The property name is wrong and must be change to AVDD28, which is a consumer (power input), not a power-supply. => description: 2.8 volt power input for microphones (AU_VIN0, AU_VIN1, AU_VIN2) - IMHO, move this property to the next parent (pwrap) isn't consistent. It should be moved back to Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml (Done in the V4) into audio-codec substystem, beside mediatek,micbias0-microvolt Does this sound good to you ? -- Regards, Alexandre