From: Krzysztof Kozlowski <krzk@kernel.org>
To: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>,
Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: sound: add WSA8855 bindings
Date: Tue, 7 Jul 2026 15:13:13 +0200 [thread overview]
Message-ID: <96e3edaa-3fac-4006-9941-5e620e61f3b4@kernel.org> (raw)
In-Reply-To: <20260701135913.1641328-2-prasad.kumpatla@oss.qualcomm.com>
On 01/07/2026 15:59, Prasad Kumpatla wrote:
> +maintainers:
> + - Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> +
> +description:
> + WSA885X is a Qualcomm Aqstic stereo smart speaker amplifier. It uses a PCM
> + audio interface, an I2C control interface, and a Class-H amplifier path for
> + high efficiency, low output noise, and low idle power consumption.
> +
> +allOf:
> + - $ref: dai-common.yaml#
> +
> +properties:
> + compatible:
> + const: qcom,wsa8855
This will need exception and I am in process of rewriting qcom-soc file.
I can include this one there.
> +
> + reg:
> + maxItems: 1
> +
> + '#sound-dai-cells':
> + const: 0
> +
> + powerdown-gpios:
> + description: GPIO controlling the SD_N powerdown pin.
> + maxItems: 1
So the pin will never be shared? Are you sure? This is discouraged and
it looks like you upstream old code.
> +
> + interrupts:
> + maxItems: 1
> +
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-07 13:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 13:59 [PATCH v2 0/2] ASoC: add Qualcomm WSA885X codec support Prasad Kumpatla
2026-07-01 13:59 ` [PATCH v2 1/2] dt-bindings: sound: add WSA8855 bindings Prasad Kumpatla
2026-07-01 16:39 ` Rob Herring (Arm)
2026-07-07 13:13 ` Krzysztof Kozlowski [this message]
2026-07-07 13:40 ` Krzysztof Kozlowski
2026-07-07 17:47 ` Prasad Kumpatla
2026-07-07 17:46 ` Prasad Kumpatla
2026-07-01 13:59 ` [PATCH v2 2/2] ASoC: codecs: add Qualcomm WSA885X codec driver Prasad Kumpatla
2026-07-03 15:07 ` Mark Brown
2026-07-07 12:44 ` Prasad Kumpatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96e3edaa-3fac-4006-9941-5e620e61f3b4@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=prasad.kumpatla@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
--cc=srinivas.kandagatla@oss.qualcomm.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox