From: Cezary Rojewski <cezary.rojewski@intel.com>
To: <phucduc.bui@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"Peter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
<linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
"Liam Girdwood" <liam.r.girdwood@linux.intel.com>
Subject: Re: [PATCH v3 0/5] ASoC: Intel: Convert locking to guard()/scoped_guard()
Date: Tue, 23 Jun 2026 21:55:00 +0200 [thread overview]
Message-ID: <9b332fe4-ed5b-4e29-b607-2850a0789929@intel.com> (raw)
In-Reply-To: <20260623105721.25865-1-phucduc.bui@gmail.com>
On 6/23/2026 12:57 PM, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> Hi all,
>
> This series converts mutex and spinlock handling in Intel ASoC drivers
> to use guard()/scoped_guard() helpers.
>
> Most changes are straightforward conversions intended to simplify lock
> handling and cleanup paths, with no intended functional changes.
>
> The series has been compile-tested only.
...
> bui duc phuc (5):
> ASoC: intel: sst-mfld-platform-pcm: Use __free(kfree) for stream
> pointer
> ASoC: Intel: avs: Use guard() for locking
> ASoC: Intel: avs: Use scoped_guard() for scoped locking
> ASoC: Intel: atom: Use scoped_guard() for scoped locking
> ASoC: Intel: atom: Use guard() for locking
The order is off just by looking at it. On top of what I mentioned in
1/5, please fix the ordering so that both avs and atom drivers receive
updates in the same manner.
TLDR:
1. ASoC: Intel: avs: Use guard() for locking
2. ASoC: Intel: avs: Use scoped_guard() for scoped locking
3. ASoC: Intel: atom: Use guard() for locking
4. ASoC: Intel: atom: Use scoped_guard() for scoped locking
5. ASoC: Intel: atom: Use __free(kfree) for stream pointer
Kind regards,
Czarek
prev parent reply other threads:[~2026-06-23 19:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 10:57 [PATCH v3 0/5] ASoC: Intel: Convert locking to guard()/scoped_guard() phucduc.bui
2026-06-23 10:57 ` [PATCH v3 1/5] ASoC: intel: sst-mfld-platform-pcm: Use __free(kfree) for stream pointer phucduc.bui
2026-06-23 19:35 ` Cezary Rojewski
2026-06-23 10:57 ` [PATCH v3 2/5] ASoC: Intel: avs: Use guard() for locking phucduc.bui
2026-06-23 19:46 ` Cezary Rojewski
2026-06-23 10:57 ` [PATCH v3 3/5] ASoC: Intel: avs: Use scoped_guard() for scoped locking phucduc.bui
2026-06-23 10:57 ` [PATCH v3 4/5] ASoC: Intel: atom: " phucduc.bui
2026-06-23 10:57 ` [PATCH v3 5/5] ASoC: Intel: atom: Use guard() for locking phucduc.bui
2026-06-23 19:56 ` Cezary Rojewski
2026-06-23 19:55 ` Cezary Rojewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b332fe4-ed5b-4e29-b607-2850a0789929@intel.com \
--to=cezary.rojewski@intel.com \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=phucduc.bui@gmail.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox