Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Alexandre Mergnat <amergnat@baylibre.com>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Lee Jones" <lee@kernel.org>, "Flora Fu" <flora.fu@mediatek.com>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Christian König" <christian.koenig@amd.com>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Will Deacon" <will@kernel.org>, "Rob Herring" <robh@kernel.org>
Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-media@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH v3 01/18] ASoC: dt-bindings: mediatek,mt8365-afe: Add audio afe document
Date: Wed, 10 Apr 2024 11:29:11 +0200	[thread overview]
Message-ID: <9ecf2158-10d1-47b3-a02f-54a4cddbf426@baylibre.com> (raw)
In-Reply-To: <e0b48da7-b33c-45e4-b3f3-a6d71bb0afe2@linaro.org>



On 09/04/2024 17:46, Krzysztof Kozlowski wrote:
>> +    soc {
>> +        #address-cells = <2>;
>> +        #size-cells = <2>;
>> +
>> +        afe@11220000 {
> Did you implement the comment or decided to keep afe?
> 

Though it was clear according to [1]:
"
Audio Front End, this is the same name used for other MTK SoC, to be
consistent.

Cook a new patch serie to change "afe" by "audio-controller" for all MTK
SoC would be great.
"

I want to keep it and fix it later with ALL other MTK SoC.
You didn't answer after that, I though it was ok for you...
So if you don't agree with that, just tell me to change it instead of 
let me think I've the choice.


> BTW, whatever "consistency" you have in mind, it does not really matter
> that much for that example. And for sure do not add incorrect code
> intentionally just to fix it in next patch.

I don't get your point.
What do you mean by "do not add incorrect code intentionally" please ???


My PoV: I implement my bindings aligned to ALL other MTK SoC, which have 
been validated by you in the past. I can understand the copied code is 
wrong, but I've suggested a solution and you didn't NACK it.

I fell like you bully me. Are you ok to stop insinuating bad things 
please and tell me directly if a fix is mandatory and if you are waiting 
for a specific one, tell me directly to avoid this kind of unpleasant 
talk and waste of time, I know maintainers are busy persons.

Beside that, thanks for your reviews.

[1]: 
https://lore.kernel.org/all/eeb3329b-0558-4237-8343-4e11f65a6a35@baylibre.com/

-- 
Regards,
Alexandre

  reply	other threads:[~2024-04-10  9:29 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-09 13:41 [PATCH v3 00/18] Add audio support for the MediaTek Genio 350-evk board Alexandre Mergnat
2024-04-09 13:41 ` [PATCH v3 01/18] ASoC: dt-bindings: mediatek,mt8365-afe: Add audio afe document Alexandre Mergnat
2024-04-09 15:46   ` Krzysztof Kozlowski
2024-04-10  9:29     ` Alexandre Mergnat [this message]
2024-04-13 21:44       ` Krzysztof Kozlowski
2024-04-09 13:42 ` [PATCH v3 02/18] ASoC: dt-bindings: mediatek,mt8365-mt6357: Add audio sound card document Alexandre Mergnat
2024-04-09 15:51   ` Krzysztof Kozlowski
2024-04-09 13:42 ` [PATCH v3 03/18] ASoC: dt-bindings: mt6357: Add audio codec document Alexandre Mergnat
2024-04-09 15:55   ` Krzysztof Kozlowski
2024-04-23 17:07     ` Alexandre Mergnat
2024-04-25  6:38       ` Krzysztof Kozlowski
2024-04-09 13:42 ` [PATCH v3 04/18] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC Alexandre Mergnat
2024-04-09 15:56   ` Krzysztof Kozlowski
2024-04-09 13:42 ` [PATCH v3 05/18] ASoC: mediatek: mt8365: Add common header Alexandre Mergnat
2024-04-09 13:42 ` [PATCH v3 06/18] SoC: mediatek: mt8365: support audio clock control Alexandre Mergnat
2024-04-09 13:42 ` [PATCH v3 07/18] ASoC: mediatek: mt8365: Add I2S DAI support Alexandre Mergnat
2024-04-09 13:42 ` [PATCH v3 08/18] ASoC: mediatek: mt8365: Add ADDA " Alexandre Mergnat
2024-04-09 13:42 ` [PATCH v3 09/18] ASoC: mediatek: mt8365: Add DMIC " Alexandre Mergnat
2024-04-09 13:42 ` [PATCH v3 10/18] ASoC: mediatek: mt8365: Add PCM " Alexandre Mergnat
2024-04-09 13:42 ` [PATCH v3 11/18] ASoc: mediatek: mt8365: Add a specific soundcard for EVK amergnat
2024-04-09 13:42 ` [PATCH v3 12/18] ASoC: mediatek: mt8365: Add platform driver Alexandre Mergnat
2024-04-09 13:42 ` [PATCH v3 13/18] ASoC: codecs: add MT6357 support amergnat
2024-04-09 13:42 ` [PATCH v3 14/18] ASoC: mediatek: Add MT8365 support Alexandre Mergnat
2024-04-09 13:42 ` [PATCH v3 15/18] arm64: defconfig: enable mt8365 sound Alexandre Mergnat
2024-04-09 13:42 ` [PATCH v3 16/18] arm64: dts: mediatek: add mt6357 audio codec support Alexandre Mergnat
2024-04-09 15:58   ` Krzysztof Kozlowski
2024-04-09 13:42 ` [PATCH v3 17/18] arm64: dts: mediatek: add afe support for mt8365 SoC Alexandre Mergnat
2024-04-09 13:42 ` [PATCH v3 18/18] arm64: dts: mediatek: add audio support for mt8365-evk Alexandre Mergnat
2024-04-09 16:00   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ecf2158-10d1-47b3-a02f-54a4cddbf426@baylibre.com \
    --to=amergnat@baylibre.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=christian.koenig@amd.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=flora.fu@mediatek.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lee@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=perex@perex.cz \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sumit.semwal@linaro.org \
    --cc=tiwai@suse.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox