From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9132E157495 for ; Mon, 11 Nov 2024 11:15:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731323741; cv=none; b=s6Lofv/duia9yhnyqYEndM9k0eFmkYT20PoMKPzUeZPrNCs5RaO5ejDxHdqnP3r5rxh1iYinj7qMvXZRSwRMAiOwzK6Dh3LKLm9OeVyO/jLBrBnVuptE/n6T58vtdbU2iDeN0mq+upMybqO6WOTQtlv181AuESPMIckJ33MsEyQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731323741; c=relaxed/simple; bh=UVMY3jncP8KlbJgHSOQbnrh0HSPCD2duUy36Ssl4JeY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EcGiUP/ehUr6nN6EabNxPhtoLSvysP6DmTEBddseZB8YHSVesu4Z1O6RmM6EEQReCwIiVccJ0pBeBKEtPWnmNTclhxahRsO5Ywz4+EktB01HQT4uuMpYUQHbpGsIiTVLiC7ijisozCG9hX+xRzmGzrGI4w8fX+h7gZD3pxVbH3c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=OnwcAa7i; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="OnwcAa7i" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a9eb3794a04so677548666b.3 for ; Mon, 11 Nov 2024 03:15:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1731323737; x=1731928537; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bhZZuPjatSrdZhX9k+zXeie/9aFPE96IB3h2Z1yS2Hc=; b=OnwcAa7iFccdMPXmNNfuo+XSwSVwwhr08r0lXMAp/OEFWu00qv7wHWnONDdCu/5q7C W+/EI+WP3Z4aGv/Ppvei6+w6/cbz/ivJ1SatoGSfcVKgMOCcmzaLKkwV1G11XNH6ap7P 4csA/TfJeSCCpI9ss7PEYectSu1/wz3ulgSj62rdCy3uN3X/rG3ip6lo302p20aszzWf J7j5szIPJqSllJjvLBWecWqsy9XqeDSJLTBldqwznATzvsQT9vUSJGUcbQ6+bY4if8Y4 HOBtESNHHgYU2Ok3fGARnCPQDliwu771U7Z11sWnW0I+BBPQ1Gd6PZSkb3JN8n72IqO/ AXCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731323737; x=1731928537; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bhZZuPjatSrdZhX9k+zXeie/9aFPE96IB3h2Z1yS2Hc=; b=X/Hhy9I0T56oy4b5X9N5jtkYGx14imK3uccUCNuKH3uXkyRpR49MHkJ8gUfvNZe17z TnsbxU31am0Cqx9KjSap0RLobVm1FFDKTFTC2atmxLePum5TKGNHo/fXyJeseTHJSd7h Uq2I9Fpw29ACo0iOU4sifB3Rl/XxTpnYWn2xAceb1wSScCRS++DH5fTpB9yYWHNUFD5F WPRqFLDInudabghMM0WmatAY4JpEtuIi+9Vkrj3vM8tXKDMIJTpdevUfst1sutSNfBMb 1X013BsE/GrdPhmr7fx2rhk3Pw+ZhqCRH190TnAKo/xMcR8nv1lQygyFWqfMVs/LrKaw yQJw== X-Forwarded-Encrypted: i=1; AJvYcCWjuTaim8PvbcSBF2QDfqL+s5rKYErijiRa+1d++S0c2kAlMZRk3N/SlsyaRirva/2gF7p4Xs3jKeGR0Q==@vger.kernel.org X-Gm-Message-State: AOJu0YzoW3MMt6ZEqR49pq3z4G1kWGirihhHy/vk8K6rwb8TKkgTMC+G +5NymtFm/N9RDBZ12Sjl5hWjQcdkXneFai2hfx0Jg+pKak0w6QEbRHqUtOi6eZw= X-Google-Smtp-Source: AGHT+IFbp4VgcqWBYLe3U0yCi4vd7nmqSuzbqzRywA4zlYZMwP+tOs/p2A4kYUW8+VEuOgG9xmufbQ== X-Received: by 2002:a17:907:6d02:b0:a9a:60c1:136d with SMTP id a640c23a62f3a-a9eeff0e570mr1147950966b.22.1731323736778; Mon, 11 Nov 2024 03:15:36 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.28]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9ee0a176cbsm593593066b.23.2024.11.11.03.15.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Nov 2024 03:15:36 -0800 (PST) Message-ID: <9ef0d9df-3d6c-470a-913c-55698148d00e@tuxon.dev> Date: Mon, 11 Nov 2024 13:15:32 +0200 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 06/25] ASoC: sh: rz-ssi: Terminate all the DMA transactions Content-Language: en-US To: Biju Das , "geert+renesas@glider.be" , "mturquette@baylibre.com" , "sboyd@kernel.org" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , Prabhakar Mahadev Lad , "lgirdwood@gmail.com" , "broonie@kernel.org" , "magnus.damm@gmail.com" , "linus.walleij@linaro.org" , "perex@perex.cz" , "tiwai@suse.com" , "p.zabel@pengutronix.de" Cc: "linux-renesas-soc@vger.kernel.org" , "linux-clk@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-sound@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Claudiu Beznea , "stable@vger.kernel.org" References: <20241108104958.2931943-1-claudiu.beznea.uj@bp.renesas.com> <20241108104958.2931943-7-claudiu.beznea.uj@bp.renesas.com> From: Claudiu Beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Biju, On 10.11.2024 10:37, Biju Das wrote: > > >> -----Original Message----- >> From: Claudiu >> Sent: 08 November 2024 10:50 >> To: geert+renesas@glider.be; mturquette@baylibre.com; sboyd@kernel.org; robh@kernel.org; >> krzk+dt@kernel.org; conor+dt@kernel.org; Biju Das ; Prabhakar Mahadev Lad >> ; lgirdwood@gmail.com; broonie@kernel.org; >> magnus.damm@gmail.com; linus.walleij@linaro.org; perex@perex.cz; tiwai@suse.com; >> p.zabel@pengutronix.de >> Cc: linux-renesas-soc@vger.kernel.org; linux-clk@vger.kernel.org; devicetree@vger.kernel.org; linux- >> kernel@vger.kernel.org; linux-sound@vger.kernel.org; linux-gpio@vger.kernel.org; Claudiu.Beznea >> ; Claudiu Beznea ; stable@vger.kernel.org >> Subject: [PATCH v2 06/25] ASoC: sh: rz-ssi: Terminate all the DMA transactions >> >> From: Claudiu Beznea >> >> In case of full duplex the 1st closed stream doesn't benefit from the dmaengine_terminate_async(). >> Call it after the companion stream is closed. >> >> Fixes: 26ac471c5354 ("ASoC: sh: rz-ssi: Add SSI DMAC support") > > Maybe add fixes tag for full duplex case as the separation of > Playback/ Capture is introduced in that patch. OK > >> Cc: stable@vger.kernel.org >> Signed-off-by: Claudiu Beznea > > Reviewed-by: Biju Das > > Cheers, > Biju > >> --- >> >> Changes in v2: >> - none >> >> sound/soc/renesas/rz-ssi.c | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c index 6efd017aaa7f..2d8721156099 >> 100644 >> --- a/sound/soc/renesas/rz-ssi.c >> +++ b/sound/soc/renesas/rz-ssi.c >> @@ -415,8 +415,12 @@ static int rz_ssi_stop(struct rz_ssi_priv *ssi, struct rz_ssi_stream *strm) >> rz_ssi_reg_mask_setl(ssi, SSICR, SSICR_TEN | SSICR_REN, 0); >> >> /* Cancel all remaining DMA transactions */ >> - if (rz_ssi_is_dma_enabled(ssi)) >> - dmaengine_terminate_async(strm->dma_ch); >> + if (rz_ssi_is_dma_enabled(ssi)) { >> + if (ssi->playback.dma_ch) >> + dmaengine_terminate_async(ssi->playback.dma_ch); >> + if (ssi->capture.dma_ch) >> + dmaengine_terminate_async(ssi->capture.dma_ch); >> + } >> >> rz_ssi_set_idle(ssi); >> >> -- >> 2.39.2 >