From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27AE625485A for ; Thu, 24 Jul 2025 09:49:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753350551; cv=none; b=PDi/Rx2m6LRZeSXvvWGkq73SanW23waLtmfDa35CJ7JKUYJxpmG3ckeDZiHtmfJgz+bpKkZLVHIAH3baOQajESGb2BTIllmFqhmJq2pJoNkL6ZpHRn9PPiGDjM0VeVG45LRmjSQjwItoAcDo3xvy6n5dyqJN4Bfrhj3UiMlTMus= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753350551; c=relaxed/simple; bh=U+rR1HNut0ExpbrnkcfOSPx36ou1vMZ071sRdAv5Ll0=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=k+MV5Edz1WM0yeJtFu+cXm0wmm5Nrd23p75VjdLyEJOpNkCRSarXEB8U1w+2XYYLq4n1vqhT0p2Y+J6uz7XoLqd8KBfR604NtVKlQoYKWLrUEBPTEV1hvMFtQ//9WelGOoHLGwhmeHHBjHaR2SafW8WKxjhmDUSXtSQ5CLhc0Lg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=hAueWPVh; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="hAueWPVh" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-558fa0b2c99so628289e87.2 for ; Thu, 24 Jul 2025 02:49:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1753350547; x=1753955347; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=L9FQ9e+6QrSgFWR/zL+SarceeBtqf3W8b4WkgK0vUaU=; b=hAueWPVhBrHcHjcp7sHtqcL7blR0kQ3wezBo4znslxQY3yxLhfO9nbKIqI2zT9ghpv 29n+MZ9tWq5FbpOzQwKvShx0J8XSjoRsV+hmW6cKBFb5VoLO9Ge5vXeFPQmpsUjEXI2r /2/+sMoZXFFBVQzQMVwe3HmJu7YMqmKR8cB50= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753350547; x=1753955347; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L9FQ9e+6QrSgFWR/zL+SarceeBtqf3W8b4WkgK0vUaU=; b=pRtFYV9dR4lYoq6OqgqRs3UKVlp2TqVctS5IvOH/5KQq6hpwyXaSgU5zhikEfPg5yX Akk29FFKI5zUPHypGR3MGhtarTj/UGm1O/BsQhQdKORCggpERCPNhCkL5SbhG+1MMXiI L2IZci+jRbMaSVBF1wQc29Z0s3N95grdg2ituoAXavnaBrhjJ53+pLbmHItB0MfuR3lJ lyQi8jmt36esA+fj9KM3Bb/qQoGwPbHce2voh2di8302W9ghnBl3DaXDqU6YomK7yFbz UGmXE8Ba3K9otMQKu01WJ5BjA9mMxpqKgFNqWXNEewwkLQNdvi5YplTHruLj9aIxX1Qf eQ3A== X-Forwarded-Encrypted: i=1; AJvYcCXpA0237A8zk5MlVNr5bk2r5zaIPrCI+qTh57gKJaXRiygOzPbUOi78yNgV92fhw1Lqwwoyt12ZWiqdRw==@vger.kernel.org X-Gm-Message-State: AOJu0Yxzh6eVyugcHlIc9jExejuUXFQosY3jmSnRBI47lFH7ZpmqjNwx gsZ1IVX2j6MybMUZrMfb9jvLVc4OqQLgPOoFe7yn7uUtmeM/j2m8q0awPQkYcDJIZLAZu5OgZuP k5QtII4+W19cQQFIh6gKNDLw1XPjKSp/8Sns4QITm X-Gm-Gg: ASbGncusCZ/3Mxun+ORycWi7z8m6QWabAiJYd8hdg+lX/oGPonIIqYpKirsQr+0tPiM ieN8nTXGNmY3Jw/mJgrJP4YSoRJP59UxeAT0yvcaxy7KEu+dJRWWtQmSUMzX7VlGOZvQ2oRW+X/ 2u6Hu4bU2TLPoF/vzrhAAqpcS3X3fPnl8l4n/gwcwlSTyBgFGUUPB7z3u8DQX1PN17bCjAiQwxe i5KqaHK8fetzv2xlc43TtmqwZaf0VekpLo= X-Google-Smtp-Source: AGHT+IGzfXywNqkl7ab0cE9pUdYYCcgre/IBfX1N5nV04X+BJ3rA6VLZb3GDp2uT00oIYqG6uR1IPA8f6Im9wahsv0o= X-Received: by 2002:a05:6512:3084:b0:558:f694:a65e with SMTP id 2adb3069b0e04-55a513b2e09mr1933097e87.34.1753350547115; Thu, 24 Jul 2025 02:49:07 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250724083914.61351-1-angelogioacchino.delregno@collabora.com> <20250724083914.61351-29-angelogioacchino.delregno@collabora.com> In-Reply-To: <20250724083914.61351-29-angelogioacchino.delregno@collabora.com> From: Chen-Yu Tsai Date: Thu, 24 Jul 2025 17:48:56 +0800 X-Gm-Features: Ac12FXyvTWPQD4hmzcW0ijsxU85GUvKBlnETlBmcYtQk6_oa7dGsCrwzhdueCNE Message-ID: Subject: Re: [PATCH 28/38] arm64: dts: mediatek: mt8173: Fix pinctrl node names and cleanup To: AngeloGioacchino Del Regno Cc: linux-mediatek@lists.infradead.org, robh@kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, krzk+dt@kernel.org, conor+dt@kernel.org, chunkuang.hu@kernel.org, p.zabel@pengutronix.de, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, jassisinghbrar@gmail.com, mchehab@kernel.org, matthias.bgg@gmail.com, chunfeng.yun@mediatek.com, vkoul@kernel.org, kishon@kernel.org, sean.wang@kernel.org, linus.walleij@linaro.org, lgirdwood@gmail.com, broonie@kernel.org, andersson@kernel.org, mathieu.poirier@linaro.org, daniel.lezcano@linaro.org, tglx@linutronix.de, atenart@kernel.org, jitao.shi@mediatek.com, ck.hu@mediatek.com, houlong.wei@mediatek.com, kyrie.wu@mediatek.corp-partner.google.com, andy.teng@mediatek.com, tinghan.shen@mediatek.com, jiaxin.yu@mediatek.com, shane.chien@mediatek.com, olivia.wen@mediatek.com, granquet@baylibre.com, eugen.hristev@linaro.org, arnd@arndb.de, sam.shih@mediatek.com, jieyy.yang@mediatek.com, frank-w@public-files.de, mwalle@kernel.org, fparent@baylibre.com, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-gpio@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jul 24, 2025 at 4:40=E2=80=AFPM AngeloGioacchino Del Regno wrote: > > Fix the pinctrl node names to adhere to the bindings, as the main > pin node is supposed to be named like "uart0-pins" and the pinmux > node named like "pins-bus". > > While at it, also cleanup all of the MTK_DRIVE_(x)mA by changing > that to just the (x) number. > > Signed-off-by: AngeloGioacchino Del Regno > --- > .../boot/dts/mediatek/mt8173-elm-hana.dtsi | 34 ++--- > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 138 +++++++++--------- > arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 60 ++++---- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 28 ++-- > 4 files changed, 128 insertions(+), 132 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi b/arch/arm= 64/boot/dts/mediatek/mt8173-elm-hana.dtsi > index dfc5c2f0ddef..1004eb8ea52c 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi > @@ -5,6 +5,14 @@ > > #include "mt8173-elm.dtsi" > > +&hdmi_mux_pins { > + pins-mux { > + pinmux =3D ; > + bias-pull-up; > + output-high; > + }; > +}; > + Should probably mention that a duplicate path reference was fixed. > &i2c0 { > clock-frequency =3D <200000>; > }; > @@ -67,26 +75,16 @@ trackpad2: trackpad@2c { > }; > }; > > -&mmc1 { > - wp-gpios =3D <&pio 42 GPIO_ACTIVE_HIGH>; > -}; > - > -&pio { > - hdmi_mux_pins: hdmi_mux_pins { > - pins2 { > - pinmux =3D ; > - bias-pull-up; > - output-high; > - }; > +&mmc1_pins_default { > + pins-wp { > + pinmux =3D ; > + input-enable; > + bias-pull-up; > }; > +}; > > - mmc1_pins_default: mmc1default { > - pins_wp { > - pinmux =3D ; > - input-enable; > - bias-pull-up; > - }; > - }; > +&mmc1 { > + wp-gpios =3D <&pio 42 GPIO_ACTIVE_HIGH>; > }; > > &touchscreen { > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/bo= ot/dts/mediatek/mt8173-elm.dtsi > index 0d995b342d46..9ec930058b92 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi [...] > - bt_wake_pins: bt_wake_pins { > - pins1 { > + bt_wake_pins: bt-pins { Nit: I think the original name is better, because IIRC this is using the RX pin as a GPIO interrupt to wake the system from suspend. > + pins-wake { > pinmux =3D ; > bias-pull-up; > }; > }; > [...] > > - pins_ds { > + pins-ds { > pinmux =3D ; > drive-strength =3D ; Missed one here. > bias-pull-down =3D ; > }; [...] > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boo= t/dts/mediatek/mt8173-evb.dts > index 9fffed0ef4bf..51118a4149d8 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > +++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts [...] > @@ -245,20 +245,29 @@ pins_cmd_dat { > bias-pull-up =3D ; > }; > > - pins_clk { > + pins-clk { > pinmux =3D ; > drive-strength =3D <2>; > bias-pull-down =3D ; > }; > > - pins_rst { > + pins-rst { > pinmux =3D ; > bias-pull-up; > }; > }; > > - mmc1_pins_uhs: mmc1 { > - pins_cmd_dat { > + spi_pins_a: spi0-pins { > + pins-bus { > + pinmux =3D = , > + , > + , > + ; > + }; > + }; > + > + mmc1_pins_uhs: mmc1-uhs-pins { Wrong order? > + pins-cmd-dat { > pinmux =3D , > , > , [...] Once fixed, Reviewed-by: Chen-Yu Tsai