From: Christian Hewitt <christianshewitt@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
Baojun Xu <baojun.xu@ti.com>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] ASoC: Add support for ti,pcm5242 to the pcm512x driver
Date: Sat, 22 Jun 2024 17:05:47 +0400 [thread overview]
Message-ID: <CE6B5FD2-790B-431F-BC69-4429CE26802A@gmail.com> (raw)
In-Reply-To: <57f0036c-4412-48fa-a6f9-3fa721717be9@sirena.org.uk>
> On 22 Jun 2024, at 5:03 PM, Mark Brown <broonie@kernel.org> wrote:
>
> On Sat, Jun 22, 2024 at 12:46:03PM +0000, Christian Hewitt wrote:
>> Add a compatible string to enable support for the ti,pcm5242 DAC chip
>> in the pcm512x driver.
>>
>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
>> ---
>> sound/soc/codecs/pcm512x-i2c.c | 2 ++
>> 1 file changed, 2 insertions(+)
>
> The device appears to have SPI support too like the other devices in the
> family, why not add the ID for SPI as well:
>
> https://www.ti.com/product/PCM5242
Okay, will do. I need to send v2 anyway as I fat-fingered the chip
number in the bindings patch subject/description :(
Christian
prev parent reply other threads:[~2024-06-22 13:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-22 12:46 [PATCH 0/2] ASoC: add compatible for ti,pcm5242 Christian Hewitt
2024-06-22 12:46 ` [PATCH 1/2] dt-bindings: sound: add ti,pcm5424 to pcm512x Christian Hewitt
2024-06-22 13:05 ` Mark Brown
2024-06-22 12:46 ` [PATCH 2/2] ASoC: Add support for ti,pcm5242 to the pcm512x driver Christian Hewitt
2024-06-22 13:03 ` Mark Brown
2024-06-22 13:05 ` Christian Hewitt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CE6B5FD2-790B-431F-BC69-4429CE26802A@gmail.com \
--to=christianshewitt@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kevin-lu@ti.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox