From: "Alexey Klimov" <alexey.klimov@linaro.org>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
<linux-sound@vger.kernel.org>, <srinivas.kandagatla@linaro.org>,
<linux-arm-msm@vger.kernel.org>
Cc: <stable@vger.kernel.org>, <broonie@kernel.org>,
<dmitry.baryshkov@linaro.org>,
<pierre-louis.bossart@linux.intel.com>, <vkoul@kernel.org>,
<lgirdwood@gmail.com>, <perex@perex.cz>, <tiwai@suse.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: qcom: sdm845: add missing soundwire runtime stream alloc
Date: Fri, 11 Oct 2024 16:38:21 +0100 [thread overview]
Message-ID: <D4T37UMU6SH0.1IFHCFVO3UJ7L@linaro.org> (raw)
In-Reply-To: <f46623f3-b915-42db-a1e5-0427df310b8b@linaro.org>
On Thu Oct 10, 2024 at 6:18 AM BST, Krzysztof Kozlowski wrote:
> On 09/10/2024 23:39, Alexey Klimov wrote:
> > During the migration of Soundwire runtime stream allocation from
> > the Qualcomm Soundwire controller to SoC's soundcard drivers the sdm845
> > soundcard was forgotten.
> >
> > At this point any playback attempt or audio daemon startup, for instance
> > on sdm845-db845c (Qualcomm RB3 board), will result in stream pointer
> > NULL dereference:
>
> ...
>
> >
> > Reproduced and then fix was tested on db845c RB3 board.
> >
> > Reported-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > Cc: stable@vger.kernel.org
> > Fixes: 15c7fab0e047 ("ASoC: qcom: Move Soundwire runtime stream alloc to soundcards")
> > Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> > Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
> > ---
>
> We should fix this everywhere, not only sdm845. I'll look at remaining
> sc7280.
What about sc7180? Or is sc7180 one the platforms where soundwire is not used
and DSP is not involved?
Anyway, I don't have hw to test sc7180 or sc7280.
Thank you,
Alexey
next prev parent reply other threads:[~2024-10-11 15:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 21:39 [PATCH] ASoC: qcom: sdm845: add missing soundwire runtime stream alloc Alexey Klimov
2024-10-10 0:33 ` Steev Klimaszewski
2024-10-11 15:32 ` Alexey Klimov
2024-10-10 5:18 ` Krzysztof Kozlowski
2024-10-11 15:38 ` Alexey Klimov [this message]
2024-10-10 8:52 ` Srinivas Kandagatla
2024-10-10 16:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D4T37UMU6SH0.1IFHCFVO3UJ7L@linaro.org \
--to=alexey.klimov@linaro.org \
--cc=broonie@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox