From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EA1926E701 for ; Tue, 1 Jul 2025 23:30:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751412617; cv=none; b=qOWgDTyC0tpKDujUgbDUY9nG2EnQ/qrez98ZWOd0G5fkmYIeT28dRzfZtmK5rHjCRFZsgnrYFnTOVbelzYl+CMzcDcLoBSBMa0mlt/a095E99P80al3eByUqgWQjYK4s0IVD1QuBF6jEie/y7iga1oZz7IrZR44hnN8aokBIBvU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751412617; c=relaxed/simple; bh=zRVKdNBo3oYtirxhyyChLEgwk1WbbXOs6Ro55DSo9TU=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=aDQrGOoSXs6LqaKHH0EXK8WEmi30uCsx0s6N3qcdE6xxBcKElJd5gRVTJUgIZWPXZ8Yn46TrUSe9g8xvwtlkwerq5lXrmBuVHPjlgMHHV8F1rF8OhhUvHIcau53mxo/VoXO15rtkwLt1fH5sHEwbl1MXTLsCEd16VXDGxOWMsV4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=L6LB1v0F; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="L6LB1v0F" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4537edf2c3cso61697575e9.3 for ; Tue, 01 Jul 2025 16:30:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751412614; x=1752017414; darn=vger.kernel.org; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oxkUs9RFusjv08S72yLrh5Wg1MHFO9VcHZyNeP7ykBI=; b=L6LB1v0Fyc0x7c52HaIjxJtK5WyOscysreC0zqmWS2UbMBM7yEPzy5MZDSGRtos00F JekQ3y42bvNfK2GZOgYSz0nwd1oiY6MqrIfuENZP/Q27J49GTXZ20r/fB0fYtKpVwps6 7khnldEXzfeBrw1cHW8I1ACewuVCLLACagqTRUBPgATbzIgJjw15iaeeEHyNftoq1+0S nfIO75fZYAryeoXAfSnFrBGzht6XZsWGvWZNVGWy813+FSCbD8trYVq5/pEt59NIYnmf TTy39mSGbbDawZmc3/QLHcW6E24kMlLeeQCUCWEY6bmUzd+VR8gEu0fpMWtI8rAF7OKO WuGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751412614; x=1752017414; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=oxkUs9RFusjv08S72yLrh5Wg1MHFO9VcHZyNeP7ykBI=; b=d5CmTpgamb8AccHGRcLLhhK9194S6MvsBgKNjxqiwnCEApJtBWsmj2nGomtjZdVPpb 3FfyoYJqxV+mGwaTcdkfZm3VPWxeSb+d0bykPOtcv32n/2V5p/UUBzDQXc7hY45GkSbJ PqPZ/ywUUq/aVH/38L7uIwpnmiOTwPbJ55mtm1e+X++3D0NWyurra4ALfSD7/pTowp5r WVYO3QHCSMLDaRQFiVDGxY+4sUKcPXbO9cjJraNBQrs96+IonEFyAoGuUYi67XluyRjY qpjCLmu3ZiEvPrCkUs/xlnOvEHu073H/G1YN08LAKAPc5F9y9k9tWwbWv2wH5uz4iKyQ dRyg== X-Forwarded-Encrypted: i=1; AJvYcCXGxAilpBmt00VyMZRGympfKxlhDXR3pVdyLuWK7oNuVk5icOyuvVLge/BB+PaQK36eVV5Nlr1n7DS/Pg==@vger.kernel.org X-Gm-Message-State: AOJu0YyQwPgQ//bTQkaDlhs/sCqtkEdU8IwJNP8pvlvRaZrOkLxccIXj MOd69EFEBoJofdPhqVRjeAkKjIkfJMP2SF6aBp2SBs7AXsxRF6fPdxrKv6iA0tI9Mss= X-Gm-Gg: ASbGncteIHlKn0Jqs9fQfB5ZfplT7fFlaeA1ePLv4BJV6Q+ClJ/WWx3oq/9H6qisywR E7IhTLyQJnbhp7ixlU16+QbQOLoVK+v/Mmp8QIoKC48dQsjzKaOrS1QvHj/59Kg+T52xGWr7uHc yoG9DdSyRtgozprGw0x/qp70wxbLRP98oQa7/C5JpZFRSo4qfezGY//CTaC60ZYt4fQY4UPyHuJ hTk9jbFbGIcsq6QqA8G7UQIUzf93gZxMDVjdfAoyXeerwMbAjjP5PcQrSobLTGWVVa2/BFdMmaV /f+M1OK6wUn6dvEVNT8wGAiqtEzgWmWmBYsB7oHAit/fpoXF/gf79Awp/PxsrHAvu6nE X-Google-Smtp-Source: AGHT+IGWh47dzU/qedhk5q4wmllU/1FOhqD8rZdFeCpoKzh5IjU9RGIxJ/oggHk3EfGT1VRySLysbQ== X-Received: by 2002:a05:600c:6205:b0:43c:fc04:6d35 with SMTP id 5b1f17b1804b1-454a36deea0mr9755065e9.4.1751412613725; Tue, 01 Jul 2025 16:30:13 -0700 (PDT) Received: from localhost ([2a02:c7c:7213:c700:4dad:b69a:9c81:2e57]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453b35349f0sm25469415e9.1.2025.07.01.16.30.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 16:30:13 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 02 Jul 2025 00:30:12 +0100 Message-Id: Subject: Re: [PATCH 1/3] dt-bindings: sound: add bindings for pm4125 audio codec From: "Alexey Klimov" To: "Krzysztof Kozlowski" Cc: "Srinivas Kandagatla" , "Liam Girdwood" , "Mark Brown" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Stephen Boyd" , "Lee Jones" , "Jaroslav Kysela" , "Takashi Iwai" , , , , , "Dmitry Baryshkov" , "Srinivas Kandagatla" X-Mailer: aerc 0.20.0 References: <20250626-pm4125_audio_codec_v1-v1-0-e52933c429a0@linaro.org> <20250626-pm4125_audio_codec_v1-v1-1-e52933c429a0@linaro.org> In-Reply-To: On Mon Jun 30, 2025 at 9:21 AM BST, Krzysztof Kozlowski wrote: > On 28/06/2025 18:41, Alexey Klimov wrote: >>=20 >>>> + #address-cells =3D <1>; >>>> + #size-cells =3D <0>; >>>> + >>>> + audio-codec@f000 { >>>> + compatible =3D "qcom,pm4125-codec"; >>>> + reg =3D <0xf000>; >>>> + vdd-io-supply =3D <&pm4125_l15>; >>>> + vdd-cp-supply =3D <&pm4125_s4>; >>>> + vdd-pa-vpos-supply =3D <&pm4125_s4>; >>>> + vdd-mic-bias-supply =3D <&pm4125_l22>; >>>> + qcom,micbias1-microvolt =3D <1800000>; >>>> + qcom,micbias2-microvolt =3D <1800000>; >>>> + qcom,micbias3-microvolt =3D <1800000>; >>>> + qcom,rx-device =3D <&pm4125_rx>; >>>> + qcom,tx-device =3D <&pm4125_tx>; >>>> + #sound-dai-cells =3D <1>; >>>> + }; >>>> + }; >>>> + }; >>>> + >>>> + /* ... */ >>>> + >>>> + soundwire@a610000 { >>> >>> Drop this and next one. >>=20 >> The audio-codec node supposed to have qcom,{rx,tx}-device properties. >> If I'll drop it then the example doesn't compile well unless I am missin= g >> something? > > What did you drop and what did I ask to drop? > >>=20 >> For example when I removed soundwire tx node completely and dropped >> qcom,tx-device then: > > I did not ask to drop qcom,tx-device. Dmitry already explained. Ok. > ... > >>=20 >>>> + The audio codec IC found on Qualcomm PM4125/PM2250 PMICs. >>>> + It has RX and TX Soundwire slave devices. This bindings is for the >>>> + slave devices. >>> >>> Last sentence is redundant and makes no sense. Codec has only slave >>> devices, so how this can be anything else than for slave devices? >>=20 >> This came from other similar files that describe bindings for child code= c nodes >> of soundwire nodes. For example from qcom,wcd937x-sdw.yaml. >> Should this be rephrased to "This bindings is for the soundwire slave de= vices." ? > > You just pasted the same, so I don't get how you want to rephrase into > the same sentence. Not really. Original sentence: "This bindings is for the slave devices." Sentence from my email: "This bindings is for the soundwire slave devices." The difference is 1 word. If it doesn't work, then maybe any suggestions? Maybe "This bindings is for audio codec node that must be a child node of t= he associated soundwire master node."? Best regards, Alexey